Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1113.
CategoricalImputer(fill_value=...)always calledcat.add_categories(fill_value)on categorical columns beforefilling, so it raised
ValueError: new categories must not include old categorieswhen the value was already oneof the categories, for example when the categories were declared up front or when an already imputed frame was
transformed again. The category is now added only when it is missing.
The new test covers unordered and ordered categoricals and checks that a second
transformleaves the resultunchanged. It fails without the change.
pytest tests/test_imputation: 104 passed on both pandas 2.3.3 and 3.1.0.The same pattern in
RareLabelEncoderis handled separately in #1096.