fix: Validate SQLite project names during init - #6809
Open
angelo-lacson wants to merge 2 commits into
Open
Conversation
Signed-off-by: Angelo Lacson <angelo.lacson.work0407@gmail.com>
angelo-lacson
marked this pull request as ready for review
September 2, 2026 10:37
angelo-lacson
commented
Sep 2, 2026
angelo-lacson
left a comment
Author
There was a problem hiding this comment.
Hi, maintainers, this PR is ready for review and the workflows are awaiting approval, Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feast initcurrently accepts a hyphenated project name for the default local template, then generates a repository that cannot load because its SQLite online store rejects that name.This change validates the project name against the selected built-in template before creating the target directory. SQLite-backed templates now return the existing SQLite-specific error immediately, while the general project-name validator continues to allow hyphens.
The PR implements option 2 proposed in the issue and is a draft pending maintainer confirmation of that behavior.
Which issue(s) this PR fixes:
Fixes #6808
Checks
git commit -s)Testing Strategy
Also verified the changed files with Ruff formatting and lint checks.
Misc
The regression test confirms that
feast init hyphen-namefails with the SQLite-specific message and does not leave a partially generated directory.