Skip to content

fix: Validate SQLite project names during init - #6809

Open
angelo-lacson wants to merge 2 commits into
feast-dev:masterfrom
angelo-lacson:fix/sqlite-init-project-name
Open

fix: Validate SQLite project names during init#6809
angelo-lacson wants to merge 2 commits into
feast-dev:masterfrom
angelo-lacson:fix/sqlite-init-project-name

Conversation

@angelo-lacson

Copy link
Copy Markdown

What this PR does / why we need it:

feast init currently accepts a hyphenated project name for the default local template, then generates a repository that cannot load because its SQLite online store rejects that name.

This change validates the project name against the selected built-in template before creating the target directory. SQLite-backed templates now return the existing SQLite-specific error immediately, while the general project-name validator continues to allow hyphens.

The PR implements option 2 proposed in the issue and is a draft pending maintainer confirmation of that behavior.

Which issue(s) this PR fixes:

Fixes #6808

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change
pytest sdk/python/tests/unit/local_feast_tests/test_init.py -q
4 passed

Also verified the changed files with Ruff formatting and lint checks.

Misc

The regression test confirms that feast init hyphen-name fails with the SQLite-specific message and does not leave a partially generated directory.

Signed-off-by: Angelo Lacson <angelo.lacson.work0407@gmail.com>
@angelo-lacson
angelo-lacson marked this pull request as ready for review September 2, 2026 10:37
@angelo-lacson
angelo-lacson requested a review from a team as a code owner September 2, 2026 10:37

@angelo-lacson angelo-lacson left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, maintainers, this PR is ready for review and the workflows are awaiting approval, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feast init accepts project names incompatible with the local SQLite template

1 participant