Skip to content

update registry paths and descriptions in configuration files #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarperPR123 wants to merge 1 commit into from
Closed

update registry paths and descriptions in configuration files #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion module_0/client_gcp/feature_store.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project: feast_demo_gcp
provider: gcp
registry: gs://feast-workshop-danny/registry.pb # TODO: Replace with your bucket
registry: gs://feast-workshop-feast-workshop-2026-10-04/registry.pb # TODO: Replace with your bucket
online_store: null
offline_store:
type: file
Expand Down
2 changes: 1 addition & 1 deletion module_0/client_no_yaml/test_fetch_gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# TODO: replace with your bucket
repo_config = RepoConfig(
registry=RegistryConfig(path="gs://feast-workshop-danny/registry.pb"),
registry=RegistryConfig(path="gs://feast-workshop-feast-workshop-2026-10-04/registry.pb"),
project="feast_demo_gcp",
provider="gcp",
offline_store="file", # Could also be the OfflineStoreConfig e.g. FileOfflineStoreConfig
Expand Down
2 changes: 1 addition & 1 deletion module_0/feature_repo_gcp/data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

driver_stats = FileSource(
name="driver_stats_source",
path="gs://feast-workshop-danny/driver_stats.parquet", # TODO: Replace with your bucket
path="gs://feast-workshop-feast-workshop-2026-10-04/driver_stats.parquet", # TODO: Replace with your bucket
timestamp_field="event_timestamp",
created_timestamp_column="created",
description="A table describing the stats of a driver based on hourly logs",
Expand Down
2 changes: 1 addition & 1 deletion module_0/feature_repo_gcp/feature_store.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project: feast_demo_gcp
provider: gcp
registry: gs://feast-workshop-danny/registry.pb # TODO: Replace with your bucket
registry: gs://feast-workshop-feast-workshop-2026-10-04/registry.pb # TODO: Replace with your bucket
online_store: null
offline_store:
type: file
Expand Down
2 changes: 1 addition & 1 deletion module_0/feature_repo_gcp/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
driver_hourly_stats_view = FeatureView(
name="driver_hourly_stats",
description="Hourly features",
entities=["driver"],
entities=[driver],
ttl=timedelta(seconds=8640000000),
schema=[
Field(name="conv_rate", dtype=Float32),
Expand Down
4 changes: 2 additions & 2 deletions module_0/infra/gcp/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
variable "project_name" {
type = string
description = "The project identifier is used to uniquely namespace resources"
description = "feast-workshop-2026-10-04"
}

variable "gcp_project" {
type = string
description = "The GCP project id"
description = "feast-workshop-2026-10-04"
}