Repository navigation
Add connection timeout to avoid hanging TLS dials - #2
Merged
Merged
Conversation
getCertificate used tls.Dial with no timeout, so an unresponsive host would hang forever. Add a -timeout flag (default 10s) and switch to tls.DialWithDialer with a net.Dialer so the dial itself bounds how long we wait. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCertificateusedtls.Dialwith no timeout, so it could hang forever against an unresponsive host.-timeoutflag (flag.Duration, default10s) wired intoConfig.tls.DialWithDialer(&net.Dialer{Timeout: config.Timeout}, ...)so the dial itself is bounded; the existing error wrapping surfaces thei/o timeoutnaturally.-timeoutexample.10.255.255.1) with a 200ms timeout and asserts it returns an error within 2s rather than hanging.Test plan
go build -v ./...go vet ./...go test -v ./...go run . badssl.comstill succeedsgo run . -domain 10.255.255.1 -timeout 2sfails in ~2s instead of hanging🤖 Generated with Claude Code