Repository navigation
Conversation
install copies c2vm and c2vm-init side by side into $(PREFIX)/bin. release tags and pushes a version after running lint, test and, since CI can't boot VMs, e2e (SKIP_E2E=1 skips it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release builds even with SKIP_E2E=1, only skips e2e for SKIP_E2E=1, ignores C2VM_E2E_KERNEL, and fast-forwards to origin/main after its one fetch. e2e fails rather than skips with C2VM_E2E=1 off Apple silicon, so it can't pass without booting anything. install only copies what make build built, so sudo make install builds nothing as root, and quotes BINDIR, which the environment no longer sets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fcuny
marked this pull request as ready for review
October 26, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installcopies thec2vmandc2vm-initthatmake buildbuilt into$(BINDIR), which defaults to wherego installputs binaries (GOBIN, orGOPATH/bin). It doesn't build, sosudo make installleaves nothing root-owned in the checkout. It usesinstallrather thancpso a re-signed binary is a new file, not one overwritten in place, which Apple silicon kills at launch.make release VERSION=vX.Y.Zhas the same guards as git-balai's, runslint test build, thenmake e2eon the default kernel since CI can't boot VMs.SKIP_E2E=1skips e2e only.C2VM_E2E=1, the e2e tests fail instead of skipping off Apple silicon, so a release can't pass them without booting anything.make test/make lintmatch whatgo.ymlruns..gitignorenow coverscmd/c2vm/c2vm-init.🤖 Generated with Claude Code