Repository navigation
e2e: stop waiting for a terminal's output when c2vm has exited - #77
Merged
Merged
Conversation
waitFor polled until its timeout even after c2vm had exited, e.g. when the image couldn't be pulled, and the test failed 2 minutes later, saying c2vm was still running. Fixes #74 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When c2vm runs past its timeout, bootCmd stops it before waitFor's own deadline, so waitFor saw the output end then too. The message now fits both, next to bootCmd's "still running", and the deadline is a backstop. One ticker replaces a timer per poll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fcuny
marked this pull request as ready for review
October 25, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitFornow fails as soon as the terminal's output ends (c2vm exited, orbootCmdstopped it at its timeout) without the text, instead of polling until its own timeout. It checks the output once more first, since the last read may have brought it. Its deadline is now a backstop, a minute afterbootCmd's, and one ticker replaces a timer per poll.Checked with throwaway tests:
-t: fails in 0.72s withthe terminal's output ended before "ready" showed up, and c2vm's output in the log;sleep 600while waiting for text that never comes: after 120s,c2vm still running after 2m0s, stopping it, then the same message.make e2epasses.Fixes #74
🤖 Generated with Claude Code