Skip to content

test: closed-database and route sweeps toward 90% coverage - #658

Merged
fclairamb merged 2 commits into
mainfrom
feat/todos-2026-10-24
Oct 23, 2026
Merged

fclairamb merged 2 commits into
mainfrom
feat/todos-2026-10-24

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

What changed

  • Coverage-90 spec, pass 2 (partial: 90% not reached, spec stays in specs/todos/).
  • Closed-database sweeps on both dialects (dbcontract/closed.go, testsupport/sweep.go) and on ~30 services plus incidents.
  • Route sweep over 300+ /api/v1 routes asserting no 5xx (app/route_sweep_test.go).
  • Local vs CI gap explained: local Go 1.27.0 vs CI 1.27.3 count statements differently, and some tests are skipped in CI. Measure with GOTOOLCHAIN=go1.27.3.
  • Estimated CI-compatible coverage: 84.46% (was 83.5%). COVERAGE_MIN left at 83, to be ratcheted after a CI run confirms.
  • Tests only, no behaviour change.

Decided by autopilot

  • coverage-90: 90% is measured on the full Postgres layer, the number CI reports (recommended answer).

🤖 Generated with Claude Code

fclairamb and others added 2 commits October 24, 2026 01:09
…about 84.5%

The CI job reports 83.5% where a local run read 88.3%: the local Go
toolchain counts statements differently (1.27.0 vs 1.27.3) and browser or
ICMP tests that CI skips run locally. Measure with GOTOOLCHAIN=go1.27.3
against the CI artifact.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…bove

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.28%. Comparing base (0051280) to head (9130b41).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/internal/testsupport/sweep.go 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   85.42%   86.28%   +0.86%     
==========================================
  Files        1284     1286       +2     
  Lines      131047   131094      +47     
==========================================
+ Hits       111944   113112    +1168     
+ Misses      19094    17973    -1121     
  Partials        9        9              
Files with missing lines Coverage Δ
server/internal/db/dbcontract/closed.go 100.00% <100.00%> (ø)
server/internal/testsupport/sweep.go 97.56% <97.56%> (ø)

... and 164 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fclairamb
fclairamb merged commit ece4eb9 into main Oct 23, 2026
35 checks passed
@fclairamb
fclairamb deleted the feat/todos-2026-10-24 branch October 23, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant