Repository navigation
feat(checks): offer to resolve open incidents when a check is disabled - #648
Merged
Merged
Conversation
Converted issue #647 to a spec: needs a new resolveOpenIncidents field on the check PATCH and a product decision on opt-in vs automatic closing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PATCH accepts resolveOpenIncidents alongside enabled:false. Incidents close with the new check_disabled resolution type; notifications, email, dash0 and docs word it as disabled rather than recovered. Closes #647 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…check is disabled manually Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rom an active-state query Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…check is disabled manually Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 83.72% 83.71% -0.01%
==========================================
Files 1269 1271 +2
Lines 129812 129918 +106
==========================================
+ Hits 108682 108762 +80
- Misses 21121 21147 +26
Partials 9 9
🚀 New features to boost your workflow:
|
fclairamb
enabled auto-merge (squash)
October 23, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #647
Disabling a check by hand left its open incidents active forever, since no new results came in to resolve them. The dashboard now offers to resolve them, and the API has an opt-in flag.
What changed
PATCHon a check takesresolveOpenIncidents(default false). Withenabled: falseit resolves the check's open outage and degraded incidents. Withoutenabled: falseit is a400 VALIDATION_ERROR. Also available on the MCPupdate_checktool.check_disabled(no migration:resolution_typeis free text). Oneincident.resolvedevent per incident, pending escalations cancelled, live update published.features/incidents.md,configuration/notifications.md./applyand import don't take the new field.Batch gate:
make build-backend lint-back testgreen, dash0typecheck:e2eandlint:e2egreen, full Playwright suite 974 passed / 0 failed / 15 skipped.Decided by autopilot
specs/done/2026/10/2026-10-23-01-resolve-incidents-when-check-disabled.md, opt-in or automatic: opt-in on the API (default false), default-checked in the UI.check_disabled, not the existingdisabled(which means degraded detection turned off).🤖 Generated with Claude Code