Repository navigation
fix(ai): hold AI loops to the check's hosts after a real-secrets run - #646
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 83.72% 83.73% +0.01%
==========================================
Files 1269 1271 +2
Lines 129812 129936 +124
==========================================
+ Hits 108682 108801 +119
- Misses 21121 21126 +5
Partials 9 9
🚀 New features to boost your workflow:
|
Exact-match scrubbing cannot stop a script from handing the model an
encoded secret (base64.encode, reversal, slices). Once a generation or
repair loop has run a script with real secret values, every later
fetch_page, browser_snapshot and blank-secrets run_script of that loop
is held to the same host allowlist (the browser is refused), so the
model has nowhere to relay what it read.
A refused host built at runtime is now withheld from the error
("[a host built at runtime]"); a host the script or env spells out is
still named.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h the model Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the model Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
fclairamb
enabled auto-merge (squash)
October 23, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes finding Q1 of the 2026-10-23 security scan (medium): the AI repair and generation loops could relay an encoded secret through the model to
fetch_pageor to a run without secrets. Scrubbing only removes exact matches, so this got past the runtime host allowlist from the P1 fix (#631).Spec:
specs/done/2026/10/2026-10-23-02-ai-loop-secret-relay-through-model.md.What changed
fetch_pageonly reaches those hosts,browser_snapshotis refused, and a blank-secretsrun_scriptgets the same allowlist (repair and generation).web/docs/docs/features/ai-authored-checks.mdnow say so.origin/mainmerged in.Behaviour change: after a real-secrets run, repair and generation lose
browser_snapshotand anyfetch_pageoutside the check's hosts for the rest of that loop.Batch gate:
make build-backend lint-back testgreen.Decided by autopilot
No open questions in the spec: the recommended proposal (1, plus 3 and 4) was implemented.
🤖 Generated with Claude Code