Skip to content

Fix featureflag fetching #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NonSwag merged 1 commit into from
Oct 21, 2026
Merged

Fix featureflag fetching #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions core/src/main/java/dev/faststats/SimpleFeatureFlagService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,15 @@ final class SimpleFeatureFlagService extends SubmissionService implements Featur

@SuppressWarnings("unchecked")
<T> CompletableFuture<T> fetch(final SimpleFeatureFlag<T> flag) {
return (CompletableFuture<T>) fetchesInProgress.computeIfAbsent(flag.getId(), ignored -> createFetch(flag));
final var future = new CompletableFuture<T>();
final var existing = fetchesInProgress.putIfAbsent(flag.getId(), future);
if (existing != null) return (CompletableFuture<T>) existing;
createFetch(flag).whenComplete((value, throwable) -> {
fetchesInProgress.remove(flag.getId(), future);
if (throwable != null) future.completeExceptionally(throwable);
else future.complete(value);
});
return future;
}

<T> CompletableFuture<T> optIn(final SimpleFeatureFlag<T> flag) {
Expand All @@ -72,8 +80,7 @@ private <T> CompletableFuture<T> createFetch(final SimpleFeatureFlag<T> flag) {
final var request = createRequest(CHECK_PATH, requestBody);
logger.info("Fetching %s: %s", request.uri(), requestBody.toString());
return HTTP_CLIENT.sendAsync(request, HttpResponse.BodyHandlers.ofString())
.thenApply(response -> handleFetchResponse(flag, response))
.whenComplete((ignored, throwable) -> fetchesInProgress.remove(flag.getId()));
.thenApply(response -> handleFetchResponse(flag, response));
}

private JsonObject createRequestBody(final SimpleFeatureFlag<?> flag) {
Expand Down
4 changes: 1 addition & 3 deletions core/src/test/java/dev/faststats/FeatureFlagTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,7 @@ private void handle(final Socket client) {
}

final var body = new String(bodyChars, 0, read);
final var e = new Request(path, headers, body.isEmpty() ? new JsonObject() : JsonParser.parseString(body).getAsJsonObject());
System.out.println("parsed body: " + body + ", " + e.body);
requests.add(e);
requests.add(new Request(path, headers, body.isEmpty() ? new JsonObject() : JsonParser.parseString(body).getAsJsonObject()));

final var response = responses.poll(1, TimeUnit.SECONDS);
if (response == null) throw new AssertionError("No response enqueued");
Expand Down
Loading