Skip to content

Recover sync batches containing large transactions - #7657

Merged
ComputelessComputer merged 2 commits into
mainfrom
fix/anlg-370-recover-large-sync-versions
Sep 17, 2026
Merged

ComputelessComputer merged 2 commits into
mainfrom
fix/anlg-370-recover-large-sync-versions

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Allow the earliest complete database version to exceed the row target while retaining byte and chunk limits, so a large transaction cannot permanently stall sync.

Adds regressions for restart replay, later edits, incomplete streams, and send confirmation. ANLG-370.


Summary by cubic

Allows a sync batch to contain a single large database version that exceeds the row target, as long as it fits within byte and chunk limits, so a large transaction no longer permanently stalls sync. Fixes ANLG-370.

  • Derives remaining work from the first-chunk watermark so later edits stay pending after the oversized version is sent.
  • Adds regression tests for restart replay, later edits, incomplete streams, and send confirmation.

Written for commit 956623f. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread crates/cloudsync/src/network.rs
Allow the earliest complete database version to exceed the row target while retaining byte and chunk limits. Cover restart replay, later edits, incomplete streams, and send confirmation. ANLG-370.
Cover the first-chunk watermark contract and a one-row target so later edits remain pending after the indivisible version is sent. ANLG-370.
@ComputelessComputer
ComputelessComputer force-pushed the fix/anlg-370-recover-large-sync-versions branch from 56b79dd to 956623f Compare September 17, 2026 06:12
@ComputelessComputer
ComputelessComputer merged commit 9c7f5d0 into main Sep 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant