Skip to content

fix: use AVV_ERR_PARENT_PLG_LOADED when parent plugin is loaded - #361

Merged
mcollina merged 1 commit into
mainfrom
fix/parent-plugin-loaded-error
Aug 24, 2026
Merged

mcollina merged 1 commit into
mainfrom
fix/parent-plugin-loaded-error

Conversation

@Tony133

@Tony133 Tony133 commented Aug 23, 2026 •

Copy link
Copy Markdown
Member

Proposal:

  • Use AVV_ERR_PARENT_PLG_LOADED instead of the generic Error when attempting to load a plugin after its parent has already been loaded.
  • AVV_ERR_PARENT_PLG_LOADED is already defined specifically for this condition, but it was not being used.
  • Using the custom error provides the expected Avvio error code and a meaningful error message while preserving the existing control flow.

Behavior:

  • No changes to the plugin loading logic. The same condition still throws and prevents the plugin from being enqueued.
  • Update the existing test to assert the AVV_ERR_PARENT_PLG_LOADED error code.

@Tony133
Tony133 force-pushed the fix/parent-plugin-loaded-error branch 2 times, most recently from c58cf59 to 4cad394 Compare August 23, 2026 08:58
@Tony133
Tony133 force-pushed the fix/parent-plugin-loaded-error branch from 4cad394 to b963a7b Compare August 23, 2026 09:00
@Tony133
Tony133 marked this pull request as ready for review August 23, 2026 09:01
@Tony133
Tony133 requested a review from a team August 23, 2026 09:01

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 7d18483 into main Aug 24, 2026
20 checks passed
@mcollina
mcollina deleted the fix/parent-plugin-loaded-error branch August 24, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants