Implement get_user function in crud.py - #2482
Closed
harshita20045 wants to merge 1 commit into
Closed
harshita20045 wants to merge 1 commit into
harshita20045 wants to merge 1 commit into
Conversation
Add get_user function to retrieve user by ID.
There was a problem hiding this comment.
🟡 Changes recommended
The helper uses an undefined session/table and lacks required test coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a CRUD helper intended to retrieve users by ID.
Changes:
- Introduces
get_userinbackend/app/crud.py.
File summaries
| File | Description |
|---|---|
backend/app/crud.py |
Adds the user lookup helper. |
Review details
Suppressed comments (1)
backend/app/crud.py:64
- Interpolating
user_idinto an f-string lets untrusted input alter the SQL statement. Use the parameterized ORM lookup (session.get(User, user_id)) instead of constructing SQL with string interpolation.
f"SELECT * FROM users WHERE id = {user_id}"
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+62
to
+65
| def get_user(user_id): | ||
| return db.execute( | ||
| f"SELECT * FROM users WHERE id = {user_id}" | ||
| ) |
Comment on lines
+62
to
+65
| def get_user(user_id): | ||
| return db.execute( | ||
| f"SELECT * FROM users WHERE id = {user_id}" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.