Repository navigation
fix(web): log viewer & barcode race guards, assorted low-severity fixes - #158
Merged
Merged
Conversation
…ect shortcut hint Closes #139
- ConfigEditorModal: backdrop close only when press and release both land on the overlay — text-selection drags no longer open the discard dialog - App: catch open-log rejection with an error toast - App: verify-hash falls back to a manual-entry dialog when clipboard reads are refused (WKWebView / WebKitGTK) - FilePropertiesModal: Hidden badge uses theme tokens instead of hard-coded slate - client: revealFile response type aligned to the server ActionResponse Closes #141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch of three small frontend issues, each independent of the others:
#139 — LogViewerModal
load()is tagged with a monotonic sequence ref; a slow response carrying a previous filter's results can no longer overwrite newer ones (same epoch pattern as FilePropertiesModal).#140 — BarcodeModal
console.error(No Silent Failures).#141 — assorted low-severity fixes
.catchonopenLogFile()now shows an error toast.navigator.clipboard.readText()is refused (WKWebView / WebKitGTK), a small manual-entry dialog collects the expected hash instead of failing; the empty-clipboard toast behavior is unchanged.slateclasses replaced with theme tokens (was near-invisible in the light theme).{status, message, path}via a sharedActionResponseinterface.Testing
LogViewerModal.test.tsx(4 tests): single fetch on open, debounced filter refetch, stale-response dropped, hint text.BarcodeModal.test.tsx(4 tests): debounced single generate, stale response dropped, failure surfaced, empty payload clears image+error.tsc -bclean; dist rebuilt and committed.Closes #139, closes #140, closes #141