Repository navigation
feat(editor): actions in header + footer status bar with Problems panel (#101 #105) - #109
Merged
falbany merged 1 commit intoNov 4, 2026
Conversation
…el (#101 #105) Issue #101 - all editor actions live in the header bar (New, Test, Revert, Save, Save As, Apply, Load config file..., Open in OS, close); the standalone toolbar row is gone. 'Load config file...' raises the config picker from inside the editor: the picker renders after the editor (same z-scale token, DOM order paints it on top) and its onLoaded bumps the editor's reloadKey so an open editor re-fetches the freshly picked file. The StatusBar loses the 'Load config...' entry point and its onLoadConfig/activeConfigName props; FileListTable's picker-raising prop is renamed onOpenConfig -> onLoadConfig so the same name means the same thing everywhere (issue #101 consistency cleanup). Issue #105 - a thin footer status bar replaces the inline banner: validity chip (Valid / n issues / validating... / not validated; clicking toggles the Problems panel), Unsaved-changes dot (role=status), action outcome (aria-live polite), Ln/Col cursor position, format and filename. A collapsible right-hand Problems panel (~280px) lists ValidationIssues with severity icons and keyboard-focusable rows; auto-opens on validation failure (Test, save gate, 400 validation lists), resets on modal close/reopen, and closes on edit together with the rest of the stale feedback (#102). The compliance-gate ConfirmDialog is unchanged. Tests: header carries every action, load-config wiring + reload, chip/ cursor/dirty/status in the footer, panel auto-open/toggle/reset. Full suite: 241 passed (14 files). dist rebuilt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
Closes #105
One PR for both follow-ups to the YAML config editor (#95), continuing the stacked editor-fix series (#106-#108).
Issue #101 — header consolidation + load config inside the editor
editor-toolbarrow is gone — no second chrome band.onLoadConfigprop) raises the existingLoadConfigModalfrom inside the editor:ConfigEditorModalis rendered before the picker inApp.tsx, so the picker (same--z-modalscale) paints on top while the editor stays mounted.LoadConfigModal.onLoadedbumps a neweditorReloadKey, passed asreloadKey— the editor re-runs its load-on-open fetch and swaps to the freshly picked file (no stale text).onLoadConfig+activeConfigNameprops removed; "Config" still opens the editor.FileListTable's picker-raising prop renamedonOpenConfig→onLoadConfig, so the same name means the same thing everywhere.Issue #105 — footer status bar + Problems panel
Valid(success) /n issues(danger) /Validating…(spinner) /Not validated— clicking toggles the Problems panel;● Unsaved changesdot (role="status", moved from the old toolbar chip); action-outcome message (editor-status,aria-live="polite").Ln x, Col y(tracked from the editor's update listener),YAML, filename.aria-live="polite". Auto-opens on validation failure — Test action, the save compliance gate, and 400 validation-list rejections; resets on modal close/reopen; closes on edit together with the rest of the stale feedback (fix(editor): stale Test/validation feedback must clear as soon as the user edits #102 semantics).ConfirmDialogis unchanged.Tests
onLoadConfigwiring, reloadKey reload) and status bar/panel (chip states, cursor tracking, auto-open, toggle/close, unsaved dot, footer status, session reset).tsc -bclean; dist rebuilt.