Skip to content

sl pull mistakes an issue number for the pull-request number #1355

Description

@omry

When a GitHub squash commit title contains both an issue reference and the appended pull-request number, Sapling selects the issue number as the pull request.

Example commit:

omry/omegaconf@93023e7

Its title is:

Preserve ValueNode types in OmegaConf.masked_copy (#813) (#1308)

#813 is an issue. The actual pull request is #1308:

omry/omegaconf#1308

Running:

$ sl pull
pulling from ssh://git@github.com/omry/omegaconf.git
warning: failed to read from Github for landed commits (RuntimeError('{
 "data": {
  "repository": {
   "pullRequest": null
  }
 },
 "errors": [
  {
   "type": "NOT_FOUND",
   "path": ["repository", "pullRequest"],
   "message": "Could not resolve to a PullRequest with the number of 813."
  }
 ]
}')), not marking commits as landed

The pull succeeds, but Sapling does not mark the corresponding local commits as landed.

Expected behavior:

sl pull should identify #1308 as the associated pull request and correctly mark the corresponding commits as landed.

Environment:

Sapling 0.2.20260317-201835+0234c21f

Related reports with the same top-level warning but different causes:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions