Update version to 11.10.0 for 11.9 release - #15096
Conversation
|
| Check | Count |
|---|---|
cert-err58-cpp |
1 |
cppcoreguidelines-pro-type-member-init |
1 |
cppcoreguidelines-special-member-functions |
2 |
performance-inefficient-string-concatenation |
1 |
performance-inefficient-vector-operation |
1 |
readability-isolate-declaration |
6 |
| Total | 12 |
Details
db/db_flush_test.cc (3 warning(s))
db/db_flush_test.cc:4100:5: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
db/db_flush_test.cc:4101:5: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
db/db_flush_test.cc:4102:5: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
db/db_secondary_test.cc (1 warning(s))
db/db_secondary_test.cc:1100:7: warning: class 'DBSecondaryCatchUpFaultTest' defines a non-default destructor but does not define a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
table/block_based/block_based_table_builder.cc (1 warning(s))
table/block_based/block_based_table_builder.cc:2602:3: warning: uninitialized record type: 'trailer' [cppcoreguidelines-pro-type-member-init]
table/sst_file_reader_test.cc (4 warning(s))
table/sst_file_reader_test.cc:687:3: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
table/sst_file_reader_test.cc:688:3: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
table/sst_file_reader_test.cc:689:3: warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
table/sst_file_reader_test.cc:698:5: warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation]
table/table_properties.cc (1 warning(s))
table/table_properties.cc:397:41: warning: initialization of 'kUserKeyCommonPrefix' with static storage duration may throw an exception that cannot be caught [cert-err58-cpp]
util/compression_test.cc (1 warning(s))
util/compression_test.cc:947:10: warning: class 'SyncPointCleanup' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
util/slice_test.cc (1 warning(s))
util/slice_test.cc:818:31: warning: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation]
Claude Code Review - OBSOLETESuperseded by a newer AI review. Expand to see the original review.✅ Claude Code ReviewAuto-triggered after CI reached the early-review threshold — reviewing commit 538a59e SummaryThis is a mechanical release-workflow PR (version bump + release note consolidation) with no logic, API, or behavioral changes. All 17 No high-severity findings. Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMNone. 🟢 LOW / NITL1. Date in HISTORY.md —
|
| File | Change | Risk |
|---|---|---|
include/rocksdb/version.h |
ROCKSDB_MINOR 9 → 10 |
None — standard post-release bump |
tools/check_format_compatible.sh |
Append "11.9.fb" to db_forward_with_options_refs |
None — adds new branch to compatibility test list |
HISTORY.md |
Insert 11.9.0 release notes | None — documentation only |
unreleased_history/** (17 files) |
Deleted | None — content moved to HISTORY.md |
No alternative execution contexts, concurrency concerns, or data-flow impacts apply.
Verification
- Version bump: 11.9 → 11.10 is correct (main tracks the next planned release).
- Compatibility refs:
"11.9.fb"correctly appended at the end of the array, maintaining chronological order. - Release notes completeness: All 17 deleted
unreleased_history/files have their content present in the new## 11.9.0section of HISTORY.md:- 6 new features ✓
- 8 public API changes ✓
- 1 bug fix ✓
- 1 performance improvement ✓
- No stray unreleased_history files: The 17 files in
unreleased_history/match exactly the 17 files deleted in the diff (confirmed via glob).
Positive Observations
- Clean, well-structured release notes following established conventions.
- All unreleased history entries accounted for with no omissions.
ℹ️ About this response
Generated by Claude Code.
Review methodology: claude_md/ci_review_prompt.md
Limitations:
- Claude may miss context from files not in the diff
- Large PRs may be truncated
- Always apply human judgment to AI suggestions
Commands:
/claude-review [context]— Request a code review/claude-query <question>— Ask about the PR or codebase
Claude Code Review - OBSOLETESuperseded by a newer AI review. Expand to see the original review.✅ Claude Code ReviewAuto-triggered after CI passed — reviewing commit 538a59e SummaryMechanical release-workflow PR that bumps the development version from 11.9.0 to 11.10.0, consolidates 17 No high-severity findings. Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMNone. 🟢 LOW / NITNone. Verification Summary
Positive Observations
ℹ️ About this responseGenerated by Claude Code. Limitations:
Commands:
|
Claude Code Review - OBSOLETESuperseded by a newer AI review. Expand to see the original review.✅ Claude Code ReviewAuto-triggered after CI reached the early-review threshold — reviewing commit 68a10bf SummaryRoutine release-bookkeeping PR for 11.9. All changes are mechanical and correct. No high-severity findings. Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMNone. 🟢 LOW / NITNone. Verification
Positive Observations
ℹ️ About this responseGenerated by Claude Code. Limitations:
Commands:
|
Claude Code Review - OBSOLETESuperseded by a newer AI review. Expand to see the original review.✅ Claude Code ReviewAuto-triggered after CI reached the early-review threshold — reviewing commit d2a2bcc SummaryRoutine version-bump PR for the 11.9 release. The mechanical changes (version.h bump, compatibility script, unreleased_history cleanup) are correct. One formatting bug in HISTORY.md. High-severity findings (0): Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMM1. Duplicate
|
✅ Claude Code ReviewAuto-triggered after CI passed — reviewing commit d2a2bcc SummaryMechanical release-workflow PR (version bump 11.9→11.10, changelog sync, compatibility ref addition). Two formatting/consistency issues found in the changelog synchronization. High-severity findings (0): Full review (click to expand)Findings🔴 HIGHNone. 🟡 MEDIUMM1. Duplicate
|
| Context | Relevant? | Notes |
|---|---|---|
| All execution contexts | N/A | No runtime code changed |
Positive Observations
- The 17 unreleased_history files correctly correspond to the 17 entries added to HISTORY.md (minus the
external_table_configdeletion oversight). - The
check_format_compatible.shupdate follows the established pattern exactly. - Version bump arithmetic is correct (11.9 → 11.10, patch stays 0).
ℹ️ About this response
Generated by Claude Code.
Review methodology: claude_md/ci_review_prompt.md
Limitations:
- Claude may miss context from files not in the diff
- Large PRs may be truncated
- Always apply human judgment to AI suggestions
Commands:
/claude-review [context]— Request a code review/claude-query <question>— Ask about the PR or codebase
|
@joshkang97 has imported this pull request. If you are a Meta employee, you can view this in D116833037. |
Summary: Pull Request resolved: #15135 - Bump version.h from 11.9.0 to 11.10.0 - Add `11.9.fb` to `check_format_compatible.sh` - Sync HISTORY.md `## 11.9.` section from `11.9.fb` - Delete 17 consumed `unreleased_history/` note file(s) from main Part of 11.9 release workflow. Pull Request resolved: #15096 Reviewed By: anand1976 Differential Revision: D116833037 Pulled By: joshkang97
|
@joshkang97 merged this pull request in 330ded5. |
2 participants
Summary
11.9.fbtocheck_format_compatible.sh## 11.9.section from11.9.fbunreleased_history/note file(s) from mainPart of 11.9 release workflow.