Open
Conversation
meta-cla
bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
retyui
commented
Apr 7, 2026
| useEffect(() => { | ||
| return () => { | ||
| setIsRendered(false); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
(I am not sure if we need it)
but this effect is analog of this part of class component
componentWillUnmount() {
if (Platform.OS === 'ios') {
this.setState({isRendered: false});
}
retyui
commented
Apr 7, 2026
| Modal.displayName = 'Modal'; | ||
| // $FlowExpectedError[prop-missing] | ||
| Wrapper.Context = VirtualizedListContextResetter; | ||
| Modal.Context = VirtualizedListContextResetter; |
Contributor
Author
There was a problem hiding this comment.
this content value was not used in a Wrapper component at all
I'm don't know if we still need this
facebook-github-tools
bot
added
the
Shared with Meta
retyui
force-pushed
the
modal-as-fn-component
branch
from
c3d6566 to
cda4f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As per title.
Changelog:
[GENERAL] [CHANGED] - Convert
Modalto function componentTest Plan: