fix(breeze): fix --only-suppressed crash in lm links - #171
Draft
rootkiller6788 wants to merge 1 commit into
Draft
Conversation
LMLinksCmd._run called the DumpLinksReply instance as a function (links = links(...)), raising TypeError. Construct a new DumpLinksReply with the filtered interfaceDetails, preserving node-level fields used for the caption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
breeze lm links --only-suppressedcrashes with:In
LMLinksCmd._run(openr/py/openr/cli/commands/lm.py), theonly_suppressedbranch reassignslinks = links(...), calling theDumpLinksReplyinstance as a function instead of constructing a new one.Change
Construct a new
DumpLinksReplywith the filteredinterfaceDetails, preservingthisNodeName,nodeMetricIncrementVal, andisOverloadedso the caption (node overload / metric increment) stays correct.Why this is safe
interfaceDetailsis filtered to the suppressed (flapping) interfaces, matching the original intent of--only-suppressed.Verification
--only-suppressedis a real flag (openr/py/openr/cli/clis/lm.py) wired toLMLinksCmd.run(only_suppressed, json).DumpLinksReplyis a thrift struct (openr/if/Types.thrift) whose instances are not callable.