Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D125825860. (Because this pull request was imported automatically, there will not be any future comments.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
lzmafeature of thezipcrate so that zip archives with LZMA-compressed entries (zip compression method 14) can be unpacked. Before this change, such archives failed withcompression method not supported: 14.Cargo.toml: addlzmato thezipfeatures. This adds the pure-Rustlzma-rust2dependency.src/util/unarchive.rs: add a unit test that unpackssrc/util/testdata/lzma.zip. The file was created with7z a -tzip -mm=LZMA. The test fails without thelzmafeature.dotslash-file.md: document the zip compression methods that are supported (store, deflate, LZMA).Test plan
cargo testpasses.cargo clippyshows no new warnings compared tomain.cargo build --releasesucceeds."format": "zip"that points to an LZMA zip built with 7-Zip fails onmainand runs with this change.🤖 Generated with Claude Code