feat(theme-neutral): adopt approved palette - #5987
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Implementation follow-up: #5992. I also verified that directly importing |
cixzhang
left a comment
There was a problem hiding this comment.
Theme consumers would receive a released Neutral remap described as approved even though its canonical record is still authority: draft and keeps several local roles proposed.
Please make the release state match the owning record: ratify the exact palette and approved remap in a current Neutral record, while clearly retaining any unresolved local roles and mappings as proposals that do not ship through this change. The implementation evidence otherwise passes: focused tests, build, package/runtime palette exclusion, template sync, and representative light/dark Chromium frames.
[Reviewed by Robohands]
|
Addressed in 3125758: the current Neutral record now ratifies the exact palette and baseline remap ( |
cixzhang
left a comment
There was a problem hiding this comment.
Ruby owns Neutral’s exact palette values and mappings. This head ratifies the palette and baseline remap while keeping unresolved local roles and mappings explicitly proposed. Focused tests, build, runtime bundle exclusion, template sync, and representative light/dark Chromium frames pass.
|
@cixzhang A quick context update before re-review: after your approval, we discovered that the committed Neutral palette had been generated before the final CLI recipe changes. In particular, it still used the older shifted dark-mode stops, while the current generator uses literal stop coordinates and exact black/white endpoints in both modes. I synchronized this PR with the current The full authoring palette remains outside the runtime bundle; only Neutral's selected token values ship. Since the exact palette and mappings changed after your approval, could you please review the updated head ( |
0b0a1fb to
22b0389
Compare
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression102 added · 0 removed. View the report A repository maintainer can accept these exact frames: Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
left a comment
There was a problem hiding this comment.
Thanks for separating palette adoption from runtime mapping. The new README tells theme authors to run astryx theme palette generate …, but this head rejects that command before generating anything, so a release of this PR by itself would leave the documented workflow broken.
Please keep that instruction out until the supported generator lands, or make the command available before this release. The exact palette itself is settled and the runtime/theme evidence is clean.
[Reviewed by Robohands]
22b0389 to
8cca7f9
Compare
8cca7f9 to
4370442
Compare
|
Addressed in |
cixzhang
left a comment
There was a problem hiding this comment.
Thanks, this now keeps the approved palette reproducible without promising unavailable regeneration. The palette/runtime boundary and CLI template path both pass.
[Reviewed by Robohands]



Summary
astryx-oklch-v1recipe.Scope
This PR approves the palette itself. It deliberately does not change Neutral’s runtime semantic, syntax, or categorical token mappings; those changes are reviewed separately in #6034.
The palette remains an authoring artifact and is not attached to the production
neutralThemeobject or generated CSS. Regeneration is an explicit review step, never part of a normal theme build.Stack
Verification
Changeset
Included for
@astryxdesign/theme-neutraland@astryxdesign/cli.