Skip to content

fix(ci): only link deployed PR previews - #5697

Merged
cixzhang merged 2 commits into
facebook:mainfrom
cixzhang:fix-failed-ci-preview-links
Aug 31, 2026
Merged

fix(ci): only link deployed PR previews#5697
cixzhang merged 2 commits into
facebook:mainfrom
cixzhang:fix-failed-ci-preview-links

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

Summary

  • include Storybook and Sandbox preview links only when the source CI run succeeded and was eligible for preview deployment
  • retain the full analysis, accessibility, and visual report for failed CI runs without advertising 404 preview URLs

Why

A live audit found #5684 correctly skipped preview deployment after its CI failure, while its PR Analysis comment still linked to nonexistent Storybook and Sandbox pages.

Test plan

  • pnpm exec vitest run .github/scripts/visual-gate/workflow-concurrency.test.mjs
  • pnpm exec actionlint -ignore 'label "2-core-ubuntu-arm" is unknown' .github/workflows/pr-comment.yml
  • pnpm exec prettier --check .github/workflows/pr-comment.yml .github/scripts/visual-gate/workflow-concurrency.test.mjs
  • pnpm check:repo
  • git diff --check

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 2:15am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@cixzhang
cixzhang force-pushed the fix-failed-ci-preview-links branch from 999319a to 63835ea Compare August 31, 2026 02:11
@cixzhang
cixzhang merged commit f83cae8 into facebook:main Aug 31, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant