Skip to content

fix(cli): the login session is refreshed mid-command - #21

Merged
boyander merged 1 commit into
mainfrom
fix/session-refresh-mid-command
Nov 3, 2026
Merged

boyander merged 1 commit into
mainfrom
fix/session-refresh-mid-command

Conversation

@boyander

@boyander boyander commented Nov 3, 2026

Copy link
Copy Markdown
Member

El clon de un WordPress murió a mitad con «session expired»: el token se renovaba solo al arrancar el comando. Ahora se comprueba en cada petición; si caduca, una sola renovación compartida (mutación de la renovación compartida → rojo). Afecta a toda orden larga (restore, clone, import, deploy run).

…t starts — a long restore, clone or deploy run no longer dies with «session expired»

loadLiveCredentials refreshed the access token once, when the command
built its client; the Bearer was then fixed for the life of the command.
`faable deploy volumes clone` of a WordPress (2026-11-03) backed one app up,
waited for it, and died on the restore with «Your Faable session has
expired»: the wait outlived the token. Same for a volume restore, an import,
`deploy run --timeout 3600`. session_strategy checks the token on every
request: nothing read while it is live; when not, one refresh in flight that
every request of that moment shares (two refreshes with one refresh token
could revoke the session). FAABLE_TOKEN, API keys and OIDC are unchanged.
@boyander
boyander force-pushed the fix/session-refresh-mid-command branch from 9650ea0 to 7670a76 Compare November 3, 2026 04:34
@boyander
boyander merged commit cbff263 into main Nov 3, 2026
1 check passed
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 4.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@boyander
boyander deleted the fix/session-refresh-mid-command branch November 4, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant