Repository navigation
fix(cli): the login session is refreshed mid-command - #21
Merged
Merged
Conversation
…t starts — a long restore, clone or deploy run no longer dies with «session expired» loadLiveCredentials refreshed the access token once, when the command built its client; the Bearer was then fixed for the life of the command. `faable deploy volumes clone` of a WordPress (2026-11-03) backed one app up, waited for it, and died on the restore with «Your Faable session has expired»: the wait outlived the token. Same for a volume restore, an import, `deploy run --timeout 3600`. session_strategy checks the token on every request: nothing read while it is live; when not, one refresh in flight that every request of that moment shares (two refreshes with one refresh token could revoke the session). FAABLE_TOKEN, API keys and OIDC are unchanged.
boyander
force-pushed
the
fix/session-refresh-mid-command
branch
from
November 3, 2026 04:34
9650ea0 to
7670a76
Compare
|
🎉 This PR is included in version 4.30.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
El clon de un WordPress murió a mitad con «session expired»: el token se renovaba solo al arrancar el comando. Ahora se comprueba en cada petición; si caduca, una sola renovación compartida (mutación de la renovación compartida → rojo). Afecta a toda orden larga (restore, clone, import, deploy run).