Skip to content

feat: add forUpdate to knex loader - #704

Merged
wschurman merged 1 commit into
mainfrom
09-21-feat_add_forupdate_to_knex_loader
Sep 23, 2026
Merged

wschurman merged 1 commit into
mainfrom
09-21-feat_add_forupdate_to_knex_loader

Conversation

@wschurman

@wschurman wschurman commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Why

One common reason Expo engineers need to drop down to raw knex is that they need to use forUpdate to lock a row/rows during a transaction. This adds the functionality to entity.

How

Add forUpdate to knex SQL loader methods. Note that this requires being in a transaction and asserts it.

Test Plan

Run updated tests.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9629e36) to head (747f6e9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #704    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       109            
  Lines        18046     18093    +47     
  Branches       941      1546   +605     
==========================================
+ Hits         18046     18093    +47     
Flag Coverage Δ
integration 28.59% <98.00%> (+0.33%) ⬆️
unittest 94.81% <82.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman
wschurman marked this pull request as ready for review September 22, 2026 16:43
@wschurman
wschurman merged commit 727f166 into main Sep 23, 2026
7 checks passed
@wschurman
wschurman deleted the 09-21-feat_add_forupdate_to_knex_loader branch September 23, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants