Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4474 +/- ##
==========================================
+ Coverage 72.43% 72.66% +0.23%
==========================================
Files 975 975
Lines 46624 46715 +91
Branches 10072 10091 +19
==========================================
+ Hits 33767 33939 +172
+ Misses 11857 11786 -71
+ Partials 1000 990 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
force-pushed
the
gabe/serve-sim-recording-consumer
branch
from
September 25, 2026 18:03
a0f3012 to
1815695
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gwdp
force-pushed
the
gabe/serve-sim-recording-consumer
branch
from
September 25, 2026 18:22
1815695 to
cff9ab3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gwdp
force-pushed
the
gabe/serve-sim-recording-consumer
branch
from
September 27, 2026 23:54
cff9ab3 to
8ec7bd5
Compare
Contributor
Author
|
Codex contribution: switched the iOS Simulator recording consumer to serve-sim record-video, preserved the upload manifest, and added retry and shutdown coverage. After rebasing onto current main, I fixed wrapper-exit tracking so a live recorder remains owned by its process group; the focused 75 tests, typecheck, lint, and formatting checks pass. — Codex |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Codex <codex@openai.com>
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The session runner used record-sim to capture the framebuffer separately from serve-sim. The new serve-sim stack owns one native capture and a dedicated hardware recording encoder, so build-tools can use its recording client and keep the existing upload manifest.
Depends on expo/expo-device-hub#164–#167 being released in order before this consumer.
How
Start
serve-sim record-videofrom the selected serve-sim package after its token-bearing preview is ready, wait for its start marker, and stop with SIGINT. Recording begins with that preview; footage before serve-sim startup is outside this recording. If serve-sim stops first, it finalizes the file during shutdown while the client waits for the manifest. Give the serve-sim process group up to 90 seconds after SIGTERM before SIGKILL, even when its package-manager wrapper exits early. Remove record-sim packaging; the upload step is unchanged.Test Plan
corepack yarn jest-unit --runInBand src/steps/utils/__tests__/IosSimulatorRecordingUtils.test.ts src/steps/utils/__tests__/remoteDeviceRunSession.test.ts: 75 passed, including a wrapper-exit recording regression.corepack yarn typecheckin build-tools, rootcorepack yarn lint, and rootcorepack yarn fmt:check: passed.— Codex