Skip to content

run with all passes failed still reports Approve with comments #55

Description

@LipLoody

Seen on 0.9.2. A run where every review pass failed (subscription session limit) still prints the verdict "AI code review — Approve with comments":

  terraform-safety: FAILED (You've hit your session limit · resets 1:50am)
  cross-repo-boundary: FAILED (...)
  cluster-scaling: FAILED (...)
  kubernetes-manifests: FAILED (...)
  infra-security: FAILED (...)
All review passes failed — reporting an incomplete review.
Token usage — input 0, output 0, cache read 0, cache write 0

AI code review — Approve with comments
no findings

⚠️ The AI review could not complete: every review pass failed or timed out, so these changes were effectively NOT reviewed.

The body does say "treat this as no review", but the headline is still an approve variant. In ecr ci that posts a PR comment that reads as a green light unless you read the fine print, and the check stays green. When all passes fail (or coverage drops below some threshold) the verdict should be a distinct failed/incomplete state, not approve, and ecr ci should exit non-zero so the CI check goes red.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions