fix(help): spell Arguments-block names the way the usage line does - #80
Merged
Conversation
`omni models merge-branch --help` listed its positionals twice under two
different names:
Arguments:
<modelid> Model UUID
<branchname> Branch name
Usage:
omni models merge-branch <model-id> <branch-name> [flags]
The Arguments block exists so a reader learns that the second positional is a
branch NAME, not a UUID. That only lands if the two blocks are recognizably
about the same argument — under two spellings they read as four arguments.
The usage line has used canonicalName since #77; argumentsHelp kept calling
slugify, which lowercases but does not split camelCase. Both now use
canonicalName. Affects help text only — nothing is parsed from these strings.
Adds a spec-wide test asserting every `<placeholder>` in a generated command's
usage line appears in its Arguments block, so the two paths cannot drift apart
again silently.
Constraint: body-shorthand arg names are already authored in kebab-case, so
only the path-param branch needed changing
Confidence: high
Scope-risk: narrow
n8agrin
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omni models merge-branch --helpdescribed its two positionals twice, under two different names:The Arguments block exists to tell a reader that the second positional is a branch name, not a UUID. That only lands if both blocks are recognizably about the same argument — under two spellings they read as four arguments.
The usage line has used
canonicalNamesince #77;argumentsHelpkept callingslugify, which lowercases but doesn't split camelCase. Both now usecanonicalName.Help text only — nothing is parsed from these strings, and flag/arg matching is unaffected.
Details: scope and verification
Scope
One line in
argumentsHelp. Only the path-param branch needed it; body-shorthand arg names (model-id,prompt, …) are authored in kebab-case already and were never affected.Every generated command with a camelCase path param was showing the wrong spelling —
ai conversation-detail(<conversationid>),ai job-cancel(<jobid>),models merge-branch, and so on.After
Verification
make build && go test ./...— all packages pass.TestBuildCommand_ArgumentsSectionupdated to expect the canonical spelling, and a newTestGenerateCommands_ArgumentNamesMatchUsageLinewalks every generated command inapi/openapi.jsonand asserts each<placeholder>in the usage line appears in the Arguments block — the two are built by separate code paths, which is how they drifted in the first place.Both fail against the pre-fix code (checked by reverting the one-line change): the spec-wide test flags
ai conversation-detail,ai job-cancel, and the rest.🤖 Generated with Claude Code
https://claude.ai/code/session_01UP53YBDjhQkkn3WAqMR3sf