fix(download): recover stale partial files after HTTP 416 - #2278
Open
RezaGolriz wants to merge 1 commit into
Open
fix(download): recover stale partial files after HTTP 416#2278RezaGolriz wants to merge 1 commit into
RezaGolriz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.partialfiles when a resumed HTTP request returns 416Rangeand return a full 200 responseFixes #1914.
Why this approach
A partial file can outlive a changed mirror object or contain more bytes than the current remote file. Retrying the same unsatisfiable range cannot recover. One clean retry repairs that local state while avoiding unbounded retry loops; the completed artifact is still accepted only after the existing integrity checks pass.
Validation
uv run pytest -q src/exo/download/tests/test_download_verification.py— 7 focused recovery tests passeduv run pytest -q src/exo/download/tests— 75 passeduv run basedpyright src/exo/download/download_utils.py src/exo/download/tests/test_download_verification.pyuv run ruff check src/exo/download/download_utils.py src/exo/download/tests/test_download_verification.pyThe tests cover 416 recovery, oversized partials, a server ignoring
Rangewith 200, progress reset, bounded failure after the clean retry, and integrity mismatch behavior.