[jeffreylouden]

Description

Death By Audio was in the catalog as two manufacturer files with the same name and url: death-by-audio, which owned nothing, and deathbyaudio, which owned 30 entries. The tier list (AUREO-532) and the import lanes key on death-by-audio, so they saw an empty brand. A fast-runner greenfield import then duplicated most of the line (#958, closed unmerged).

This PR consolidates the two onto death-by-audio:

• All 30 deathbyaudio-* files (25 hardware, 5 accessories) are renamed to death-by-audio-*, and their manufacturer: is updated. Every entry keeps its id, so Studio setups and R2 images keyed on those ids are unaffected.
• data/manufacturers/death-by-audio.yaml keeps its own id and takes the description deathbyaudio.yaml carried.
• data/manufacturers/deathbyaudio.yaml is deleted, which retires its id xmDxuVu6p6h-pZQJUSesl. Hence the retirement label. Studio derives manufacturer ids from the catalog at runtime and never stores them, so nothing references the retired id.

No product content changes. New products and xCOLORWAY variants follow in a /catalog-import-merge refresh once this lands.

Type of Change

• New software/plugin entry
• New hardware entry
• New manufacturer entry
• Update to existing entry
• Bug fix
• Schema or script change

Checklist

• I have run pnpm validate and it passes
• YAML files follow the existing format (pnpm format:check clean)
• Manufacturer exists (or I'm adding it in this PR)
• Categories and formats are from the schema files (unchanged)
• Identifiers are accurate, if provided (unchanged)
• Any hp I added or changed names its source in the description (none)

Additional Notes

• check-id-immutability passes on 32 files with the retirement label. Without the label it fails, naming only deathbyaudio.yaml, which is the intended departure.
• pnpm build passes (17,128 products).
• No compatibleWith, supersedes or other slug reference pointed at a deathbyaudio-* file.

---

Generated by Claude Code

Summary by CodeRabbit

• Catalog Updates
  • Death By Audio is now listed under a single, consistent manufacturer name across its catalog entry and 30 associated products.
  • Existing product IDs remain unchanged, and the manufacturer’s description is available with the updated listing.

[changeset-bot]

🦋 Changeset detected

Latest commit: 95dd40b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
catalog	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8e7bf4a9-0f34-463a-be6d-cdadaad9bc6f

📥 Commits

Reviewing files that changed from the base of the PR and between b55304a and 95dd40b.

📒 Files selected for processing: 33

• .changeset/death-by-audio-one-manufacturer.md
• data/accessories/death-by-audio-enter-the-void-gig-bag.yaml
• data/accessories/death-by-audio-flat-pedal-trs-cable.yaml
• data/accessories/death-by-audio-mic-stand-clip-backplate-for-vocal-pedals.yaml
• data/accessories/death-by-audio-raw-power.yaml
• data/accessories/death-by-audio-trs-y-split-cable.yaml
• data/hardware/death-by-audio-absolute-destruction.yaml
• data/hardware/death-by-audio-amp-crash.yaml
• data/hardware/death-by-audio-apocalypse.yaml
• data/hardware/death-by-audio-bass-war.yaml
• data/hardware/death-by-audio-crossover-fuzz.yaml
• data/hardware/death-by-audio-disturbance.yaml
• data/hardware/death-by-audio-dream-station.yaml
• data/hardware/death-by-audio-echo-dream-2.yaml
• data/hardware/death-by-audio-echo-master-1.yaml
• data/hardware/death-by-audio-evil-filter.yaml
• data/hardware/death-by-audio-fuzz-war.yaml
• data/hardware/death-by-audio-germanium-filter.yaml
• data/hardware/death-by-audio-interstellar-overdriver.yaml
• data/hardware/death-by-audio-micro-dream.yaml
• data/hardware/death-by-audio-moonbeam-phaser.yaml
• data/hardware/death-by-audio-octave-clang.yaml
• data/hardware/death-by-audio-photomodulator.yaml
• data/hardware/death-by-audio-reverberation-machine.yaml
• data/hardware/death-by-audio-robot.yaml
• data/hardware/death-by-audio-rooms.yaml
• data/hardware/death-by-audio-space-bender.yaml
• data/hardware/death-by-audio-supersonic-fuzz-gun.yaml
• data/hardware/death-by-audio-thee-treble-overload.yaml
• data/hardware/death-by-audio-time-shadows.yaml
• data/hardware/death-by-audio-total-sonic-annihilation-2.yaml
• data/manufacturers/death-by-audio.yaml
• data/manufacturers/deathbyaudio.yaml

💤 Files with no reviewable changes: 1

• data/manufacturers/deathbyaudio.yaml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The catalog consolidates Death By Audio under the death-by-audio manufacturer ID. It removes the deathbyaudio manufacturer record, adds a description to the retained record, and updates 30 product records to reference the retained ID.

Changes

Manufacturer consolidation

Layer / File(s)	Summary
Consolidate manufacturer records .changeset/death-by-audio-one-manufacturer.md, data/manufacturers/death-by-audio.yaml, data/manufacturers/deathbyaudio.yaml	The changeset describes the ID consolidation. The retained manufacturer record gains a description, and the old record is removed.
Update product manufacturer references data/accessories/death-by-audio-*.yaml, data/hardware/death-by-audio-*.yaml	All 30 product records now reference death-by-audio instead of deathbyaudio.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 95dd4

The 30 products now use the retained Death By Audio manufacturer record while keeping their IDs and URLs. No actionable merge risk is established in the repository’s release path.

### Architecture Summary

Architecture risk: 🔵 Low · up to 95dd4

The change affects 1 system.

Changed systems: data

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — data (service) was modified; 32 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in data/accessories/death-by-audio-enter-the-void-gig-bag.yaml: The manufacturer value changes from deathbyaudio to death-by-audio.
• observed — Modified behavior in data/accessories/death-by-audio-flat-pedal-trs-cable.yaml: The manufacturer value changed from deathbyaudio to death-by-audio.
• observed — Modified behavior in data/accessories/death-by-audio-mic-stand-clip-backplate-for-vocal-pedals.yaml: The manufacturer value changes from deathbyaudio to death-by-audio.
• observed — Modified behavior in data/accessories/death-by-audio-raw-power.yaml: The manufacturer value changed from deathbyaudio to death-by-audio.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: consolidating the deathbyaudio manufacturer data into death-by-audio.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (32 skipped: 32 unsupported.)

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[jeffreylouden]

The red validate row is the run the opened event started (run 39051278835), before the retirement label was applied. That run read PR_LABELS as empty, so check-id-immutability correctly refused the departing deathbyaudio id. The labeled event's run on the same head (39051285757) passed validate and audit. Re-running the old one would replay its original payload without the label and fail the same way, so it's been left as is. Nothing on this head needs a code change.

---

Generated by Claude Code