Repository navigation
Test generator, problem_spec_dir(): remove code that walks the path - #460
Merged
Merged
Conversation
This code checks if the current path is a child of the problem spec repo. The generator lives in the track repo, which is generally not nested inside the problem spec repo. The prior logic checks the XDG cache path, which is what `configlet` uses. Contributors ought to be running `configlet sync` so the path used by the configlet ought to exist and should be reliable. As such, an additional check is not needed.
glennj
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code checks if the current path is a child of the problem spec repo.
The generator lives in the track repo, which is generally not nested inside the problem spec repo. The prior logic checks the XDG cache path, which is what
configletuses. Contributors ought to be runningconfiglet syncso the path used by the configlet ought to exist and should be reliable. As such, an additional check is not needed.