Repository navigation
fix: avoid pinning clients on failed advisory try locks (#1579 on v0.1.60) - #1
Merged
Merged
Conversation
…on v0.1.60) Port of pgdogdev#1579 onto v0.1.60. pg_try_advisory_lock[_shared] used to pin the client to its server connection even when the call returned false, so a contended try-lock leaked a pinned backend until disconnect. Top-level try-lock columns are now recorded during parsing, and the query engine reads each DataRow's boolean (honouring Bind result formats) and only tracks the session lock when it was acquired. Unreadable results or an ErrorResponse are treated as indeterminate and keep the previous optimistic pin. Adapted to v0.1.60's advisory-lock changes: AdvisoryLockId (one/two-parameter) keys, pg_catalog-qualified function names, and single-shard routing of advisory-lock queries, which keeps the row-to-lock mapping one-to-one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of pgdogdev#1579 onto v0.1.60.
pg_try_advisory_lock[_shared] used to pin the client to its server
connection even when the call returned false, so a contended try-lock
leaked a pinned backend until disconnect. Top-level try-lock columns are
now recorded during parsing, and the query engine reads each DataRow's
boolean (honouring Bind result formats) and only tracks the session lock
when it was acquired. Unreadable results or an ErrorResponse are treated
as indeterminate and keep the previous optimistic pin.
Adapted to v0.1.60's advisory-lock changes: AdvisoryLockId
(one/two-parameter) keys, pg_catalog-qualified function names, and
single-shard routing of advisory-lock queries, which keeps the
row-to-lock mapping one-to-one.