[nodejs] 25.8.0-3: switch to ninja build system#7224
Merged
Conversation
Building Node.js using Ninja is faster than using GNU Make.
Member
|
Are there any benchmark results demonstrating the improvements? |
Author
Member
|
Tasks might be dispatched to workers with different performance levels, so I don't think this comparison makes much sense. I'll give it a try locally. |
Member
|
On the same local machine, with the patch, without the patch, So it does improve the build time, while the user/sys part remains similar, thus I guess it's a concurrency issue. Anyway, thanks for your contribution! |
ziyao233
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Building Node.js using Ninja is faster than using GNU Make.