chore: bump baileys to 7.0.0-rc10 + tsx 4.21 with whatsapp-rust-bridge patch#2532
Open
DavidsonGomes wants to merge 1 commit intodevelopfrom
Open
chore: bump baileys to 7.0.0-rc10 + tsx 4.21 with whatsapp-rust-bridge patch#2532DavidsonGomes wants to merge 1 commit intodevelopfrom
DavidsonGomes wants to merge 1 commit intodevelopfrom
Conversation
…whatsapp-rust-bridge@0.5.3
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps baileys and tsx, introduces a pnpm-based patch for whatsapp-rust-bridge to fix CJS resolution, and migrates lockfile management from npm to pnpm so the patch mechanism works. Sequence diagram for dev:server startup with whatsapp-rust-bridge CJS export patchsequenceDiagram
actor Developer
participant DevServer as dev_server_script
participant tsxRunner as tsx
participant NodeLoader as node_cjs_loader
participant Baileys as baileys_module
participant Bridge as whatsapp_rust_bridge
Developer->>DevServer: run dev:server
DevServer->>tsxRunner: start tsx with entrypoint
tsxRunner->>NodeLoader: resolve baileys
NodeLoader->>Baileys: load module
Baileys->>NodeLoader: require whatsapp_rust_bridge
alt Without_pnpm_patch
NodeLoader->>Bridge: read package_json exports
NodeLoader-->>Developer: ERR_PACKAGE_PATH_NOT_EXPORTED
else With_pnpm_patch
NodeLoader->>Bridge: read patched exports (main, require, default)
NodeLoader->>Bridge: load dist/index_js
Bridge-->>Baileys: module loaded
Baileys-->>DevServer: WhatsApp connection established
DevServer-->>Developer: API running on port 8080
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- Since this repo is now effectively standardized on pnpm (lockfile + patchedDependencies), consider adding a
packageManagerfield in package.json (and/or an.npmrcthat errors onnpm install) to prevent contributors from accidentally reintroducing npm/yarn lockfiles and bypassing the patch.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this repo is now effectively standardized on pnpm (lockfile + patchedDependencies), consider adding a `packageManager` field in package.json (and/or an `.npmrc` that errors on `npm install`) to prevent contributors from accidentally reintroducing npm/yarn lockfiles and bypassing the patch.
## Individual Comments
### Comment 1
<location path="pnpm-workspace.yaml" line_range="1-2" />
<code_context>
+patchedDependencies:
+ whatsapp-rust-bridge@0.5.3: patches/whatsapp-rust-bridge@0.5.3.patch
</code_context>
<issue_to_address>
**suggestion:** Consider moving `patchedDependencies` into `package.json`'s `pnpm` config instead of introducing a workspace file.
If you don’t need pnpm workspaces and only want this patch, you can put `patchedDependencies` under a `pnpm` key in `package.json`. This keeps package-manager config centralized and avoids implying the repo is a multi-package workspace.
Suggested implementation:
```
```
Move the patch configuration into `package.json` under the `pnpm` key. For example:
```jsonc
{
// ...
"pnpm": {
"patchedDependencies": {
"whatsapp-rust-bridge@0.5.3": "patches/whatsapp-rust-bridge@0.5.3.patch"
}
}
}
```
If the repo does not actually use pnpm workspaces, you can now delete `pnpm-workspace.yaml` entirely from version control.
</issue_to_address>
### Comment 2
<location path="package.json" line_range="157" />
<code_context>
"prettier": "^3.4.2",
"tsconfig-paths": "^4.2.0",
- "tsx": "^4.20.5",
+ "tsx": "^4.21.0",
"typescript": "^5.7.2"
}
</code_context>
<issue_to_address>
**suggestion:** Declare the package manager in `package.json` now that you're moving away from `package-lock.json`.
With `package-lock.json` removed and `pnpm-workspace.yaml` added, please add a `"packageManager": "pnpm@<version>"` field in `package.json` so contributors consistently use pnpm instead of npm or yarn.
Suggested implementation:
```
"tsx": "^4.21.0",
"typescript": "^5.7.2"
},
"packageManager": "pnpm@9.15.0"
}
```
If your project standardizes on a different pnpm version, replace `9.15.0` with that exact version (e.g. the one used in CI or documented in CONTRIBUTING.md) to keep local development and automation in sync.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1
to
+2
| patchedDependencies: | ||
| whatsapp-rust-bridge@0.5.3: patches/whatsapp-rust-bridge@0.5.3.patch |
Contributor
There was a problem hiding this comment.
suggestion: Consider moving patchedDependencies into package.json's pnpm config instead of introducing a workspace file.
If you don’t need pnpm workspaces and only want this patch, you can put patchedDependencies under a pnpm key in package.json. This keeps package-manager config centralized and avoids implying the repo is a multi-package workspace.
Suggested implementation:
Move the patch configuration into package.json under the pnpm key. For example:
{
// ...
"pnpm": {
"patchedDependencies": {
"whatsapp-rust-bridge@0.5.3": "patches/whatsapp-rust-bridge@0.5.3.patch"
}
}
}If the repo does not actually use pnpm workspaces, you can now delete pnpm-workspace.yaml entirely from version control.
| "prettier": "^3.4.2", | ||
| "tsconfig-paths": "^4.2.0", | ||
| "tsx": "^4.20.5", | ||
| "tsx": "^4.21.0", |
Contributor
There was a problem hiding this comment.
suggestion: Declare the package manager in package.json now that you're moving away from package-lock.json.
With package-lock.json removed and pnpm-workspace.yaml added, please add a "packageManager": "pnpm@<version>" field in package.json so contributors consistently use pnpm instead of npm or yarn.
Suggested implementation:
"tsx": "^4.21.0",
"typescript": "^5.7.2"
},
"packageManager": "pnpm@9.15.0"
}
If your project standardizes on a different pnpm version, replace 9.15.0 with that exact version (e.g. the one used in CI or documented in CONTRIBUTING.md) to keep local development and automation in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baileysfrom7.0.0-rc.9to7.0.0-rc10andtsxfrom^4.20.5to^4.21.0.whatsapp-rust-bridge@0.5.3that addsmain,require, anddefaultto theexportsfield so the package can be resolved from CJS projects (this repo has no"type": "module").package-lock.json, addspnpm-workspace.yamlso the patch is picked up).Why
Running
npm run dev:serverondevelopwas failing with:The bridge (a transitive dependency pulled in by baileys rc10) only declares
exports.import+exports.types, with norequire/default. Because evolution-api is a CJS project, both Node and tsx resolve through the CJS loader and fail.The patch adds the missing fields without changing runtime behavior — the same
dist/index.jsis served for every condition.Test plan
pnpm installapplies the patch cleanlypnpm run dev:serverboots the API on port 8080 and connects to WhatsAppNotes for reviewers
exportsfield is missingdefault.Summary by Sourcery
Upgrade Baileys and tsx dependencies and introduce a pnpm-based patch to fix whatsapp-rust-bridge resolution in this CJS project.
Bug Fixes:
Enhancements:
Build: