Repository navigation
Conversation
…ion-cms#2553) The save redirected to the user list, which needs edit_user, so a role without it saw "You don't have enough privileges" and lost the tab even though the password had changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The form changes the viewer's own password only, yet a second manager opening it while another had it open was refused with the privilege error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A role with delete_user but not edit_user deleted the user and then got the privilege error from the list. It now lands on the dashboard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #2556 to 3.6.x, for #2553. The code had the same three defects, and the commits apply unchanged.
Changes
One commit each:
a=99), which needsedit_user, so a role without it got "You don't have enough privileges for this action!" and lost the tab, although the password had changed. It now lands on the dashboard (a=2), for every role.Password::checkLocked()refused anyone who opened the page while another manager had it open, with the same message. The form only changes the viewer's own password, so the lock is gone.delete_userbut noedit_userdeleted the user and then got the error from the list. It now goes to the list only withedit_user, otherwise to the dashboard.Verification
tests/Unit tests/Featureon PHP 8.4 (Linux): 2439 passed, 9 skipped. PHPStan: no errors.edit_user(the list still opens with it). The failures themselves were reproduced on 3.5.x, see fix(manager): stop the false privilege error after changing a password #2556.🤖 Generated with Claude Code