Repository navigation
Hold CI's Node 24 at 24.19 - #24
Merged
Merged
Conversation
On Node 24.21 the example app's tests fail before they start, because ace refuses to load its commands with "Invalid URL". The same commands load on 24.19 and on 25, and main fails the same way on 24.21, so the cause is the Node update rather than any change in this repo. Pin the matrix to 24.19 until a later 24 release passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node 24.21 the example app's functional tests fail during setup, before any test runs. ace refuses to load
examples/blog/commands/export_articles.tsand reports "Invalid command exported from export_articles.js. Invalid URL".The cause is the Node update, not a change in this repo:
main(18 August) used Node v24.19.0. GitHub's runner now installs v24.21.0.node ace listinexamples/blogworks on 24.19.0 and 25.9.0, and fails on 24.21.0 with the same error.mainfails the same way on 24.21.0.The error comes from the JSON schema validation ace runs on command metadata (the
jsonschemapackage). The exact trigger in 24.21 is not traced yet.This pins the matrix to
'24.19'with a comment, until a later Node 24 release passes. It unblocks #23. No branch protection requires the oldtests (24)job name.🤖 Generated with Claude Code