You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(admin-frontend): fields.types.ts só com blocos genéricos - #216
Refatoração sem mudança de comportamento em apps/admin-frontend/src/shared/form/fields/.
fields.types.ts misturava blocos genéricos com props de cada campo, por isso importava componentes concretos de shared/ui (Input, Textarea, InputGroupInput, ColorSwatchPickerOption). Agora ele guarda só os blocos genéricos e importa de @/shared/ui apenas form-field (FormFieldControlProps, usado por ControlledFieldProps).
components/cpf-field.tsx (base vem de masked-field)
PhoneFieldProps, EmailFieldProps
components/phone-field.tsx, components/email-field.tsx (base vem de text-fields)
BirthDateFieldProps
components/birth-date-field.tsx (base vem de date-field)
ColorFieldProps
components/color-field.tsx
SelectFieldOption, SelectFieldProps
components/select-field.tsx
SearchFieldProps
components/search-field.tsx
As definições foram movidas sem alteração. O barril index.tsx continua exportando os mesmos 14 nomes de tipo, então nada em features/ muda. Fora de shared/form/fields, nenhum arquivo foi tocado. Dentro, só select-field.test.tsx trocou a origem de SelectFieldOption.
Fora do escopo
O SearchSelectField do #207 (claude/multi-select-component-d9018b) ainda não está na main, então SearchSelectFieldProps e SearchSelectOwnedProps não foram mexidos aqui. Quando um dos dois PRs entrar, o outro precisa levar esses tipos para components/search-select-field.tsx, seguindo a mesma regra.
Validação
Em apps/admin-frontend:
npm run format:check: ok
npm run lint: 0 erros e as mesmas 6 warnings de react-refresh da main (shared/ui/badge, button, toast e src/test/renderRoutes.tsx). Nenhuma em shared/form/fields.
npm run build: ok (tsc + vite build)
npm run test:coverage -- --exclude ".claude/**": 100 arquivos e 1092 testes passando, limiares de cobertura atendidos
Não há verificação no navegador porque a mudança é só de tipos e não muda nada na tela.
Form field configuration types are now provided alongside their corresponding fields, with shared types available through the common form interface. Existing field behavior is unchanged, including optional labels and date bounds.
No changes to the admin interface’s appearance or end-user form interactions are included in this update.
As props de cada campo passam a morar no arquivo do componente que as usa
(TextFieldProps em text-fields, ColorFieldProps em color-field etc.); os
derivados importam a base do arquivo do campo base. fields.types.ts fica com
BaseFieldProps, RegisterOwnedProps, FormFieldOwnedProps, WithOptionalLabel,
FieldLabelPlacement, ControlledFieldProps e FieldErrorProps, e de shared/ui
importa só form-field. O barril exporta os mesmos nomes de tipo.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
Field-specific prop types now live in their owning component modules instead of fields.types.ts. Shared field prop utilities are exported for reuse, and the field barrel exports each prop type from its component module.
Changes: Field prop type ownership
Layer / File(s)
Summary
Export shared field prop utilities apps/admin-frontend/src/shared/form/fields/fields.types.ts
Shared field prop utilities become exported. Field-specific prop declarations are removed from this file.
Define field prop types in component modules apps/admin-frontend/src/shared/form/fields/components/*, apps/admin-frontend/src/shared/form/fields/index.tsx
Field-specific prop types are declared in their owning component modules. SelectFieldOption values use the value type at the selected form path. The barrel exports the types from those modules, and the select-field test imports SelectFieldOption from select-field.tsx.
evertonschuster/Agenza#192: Changes field contracts that this PR relocates, including MaskedFieldProps, CpfFieldProps, and date-field value types.
evertonschuster/Agenza#207: Adds SearchSelectFieldProps to fields.types.ts and the field barrel; the summary identifies its later move to the owning component module as out of scope for this PR.
Merge Risk: Minimal · up to 24f53
This refactor only relocates TypeScript types in the admin frontend and does not change runtime behavior. No actionable merge risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly summarizes the main change: refactoring fields.types.ts to retain only generic field types while moving field-specific types to component files.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 13 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1929:14)
at Object..js (node:internal/modules/cjs/loader:2060:10)
at Module.load (node:internal/modules/cjs/loader:1651:32)
at Module._load (node:internal/modules/cjs/loader:1443:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:372:15)
at ModuleWrap. (node:internal/modules/esm/translators:244:9)
at ModuleJob.run (node:internal/modules/esm/module_job:561:25)
at async node:internal/modules/esm/loader:647:26
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O quê
Refatoração sem mudança de comportamento em
apps/admin-frontend/src/shared/form/fields/.fields.types.tsmisturava blocos genéricos com props de cada campo, por isso importava componentes concretos deshared/ui(Input,Textarea,InputGroupInput,ColorSwatchPickerOption). Agora ele guarda só os blocos genéricos e importa de@/shared/uiapenasform-field(FormFieldControlProps, usado porControlledFieldProps).Onde ficou cada tipo
BaseFieldProps,RegisterOwnedProps,FormFieldOwnedProps,WithOptionalLabel,FieldLabelPlacement,ControlledFieldProps,FieldErrorPropsfields.types.ts(exportados para os componentes)TextFieldProps,TextareaFieldPropscomponents/text-fields.tsxMaskedFieldPropscomponents/masked-field.tsxDateFieldPropscomponents/date-field.tsxCpfFieldPropscomponents/cpf-field.tsx(base vem demasked-field)PhoneFieldProps,EmailFieldPropscomponents/phone-field.tsx,components/email-field.tsx(base vem detext-fields)BirthDateFieldPropscomponents/birth-date-field.tsx(base vem dedate-field)ColorFieldPropscomponents/color-field.tsxSelectFieldOption,SelectFieldPropscomponents/select-field.tsxSearchFieldPropscomponents/search-field.tsxAs definições foram movidas sem alteração. O barril
index.tsxcontinua exportando os mesmos 14 nomes de tipo, então nada emfeatures/muda. Fora deshared/form/fields, nenhum arquivo foi tocado. Dentro, sóselect-field.test.tsxtrocou a origem deSelectFieldOption.Fora do escopo
O
SearchSelectFielddo #207 (claude/multi-select-component-d9018b) ainda não está namain, entãoSearchSelectFieldPropseSearchSelectOwnedPropsnão foram mexidos aqui. Quando um dos dois PRs entrar, o outro precisa levar esses tipos paracomponents/search-select-field.tsx, seguindo a mesma regra.Validação
Em
apps/admin-frontend:npm run format:check: oknpm run lint: 0 erros e as mesmas 6 warnings dereact-refreshdamain(shared/ui/badge,button,toastesrc/test/renderRoutes.tsx). Nenhuma emshared/form/fields.npm run build: ok (tsc+vite build)npm run test:coverage -- --exclude ".claude/**": 100 arquivos e 1092 testes passando, limiares de cobertura atendidosNão há verificação no navegador porque a mudança é só de tipos e não muda nada na tela.
🤖 Generated with Claude Code
Summary by CodeRabbit