Repository navigation
Conversation
Dependabot proposed rustyline 18.0.1 -> 19.0.0 (#2765) but cannot edit `supply-chain/config.toml`, so its `Audit` job fails on the new version with nothing it can do about it. Carrying the bump and the exemption together is the only shape that lands green. A major bump, but no API migration: `bashkit-cli`'s `interactive` feature compiles unchanged against 19.0.0, so the `Editor`/`Helper` surface `src/interactive.rs` uses is unaffected. The lockfile cascade is the larger part of the diff — rustyline 19 drops its `cfg-if` edge and pulls `windows-sys` 0.52.0 -> 0.61.2 across the crates that share it (`clipboard-win`, `rustix`, `rustls-native-certs`, `tempfile`, `socket2`-adjacent shims) plus `getrandom` 0.3.4 -> 0.4.3 under `tempfile`. `cargo vet` already covers every one of those, so rustyline itself is the only unvetted crate, and its exemption moves 18.0.1 -> 19.0.0 rather than granting trust to something new. Verified on the pinned toolchain (1.95.0): - `cargo build -p bashkit-cli` (default features, so `interactive` on) clean - `cargo test -p bashkit-cli` 67/67 pass - `cargo vet --locked` succeeds - REPL smoke test through the real rustyline read loop: `printf 'echo hello-from-repl\nexit\n' | bashkit` prints `hello-from-repl` and exits 0
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 74f8aec | Commit Preview URL Branch Preview URL |
Oct 20 2026, 11:28 AM |
|
The
Both were published 2026-10-19 and have nothing to do with rustyline — this PR touches I am not porting the fix into this PR. A critical sandbox-escape advisory deserves its own clearly-titled, independently revertable PR rather than riding inside a rustyline bump where nobody would look for it. So I am closing this one to free the branch, landing the wasmtime fix first, and reopening the rustyline bump afterwards — the work is already verified and will come back unchanged (build clean, 67/67 For the record on the fix: 48.0.7 is the in-line patch, so the exact Generated by Claude Code |
What changed
rustyline18.0.1 → 19.0.0 forbashkit-cli'sinteractivefeature, with itscargo vetexemption moved to the new version in the same commit.Supersedes #2765, which proposed the same bump but cannot edit
supply-chain/config.toml, so itsAuditjob fails on the new version withnothing dependabot can do about it.
Why
A major bump, but no API migration needed:
bashkit-clicompiles unchangedagainst 19.0.0, so the
Editor/Helpersurfacesrc/interactive.rsuses isunaffected. That is the thing worth checking on a major, and it holds.
The lockfile cascade is most of the diff. rustyline 19 drops its
cfg-ifedgeand pulls
windows-sys0.52.0 → 0.61.2 through the crates that share it(
clipboard-win,rustix,rustls-native-certs,tempfileand neighbours),plus
getrandom0.3.4 → 0.4.3 undertempfile.cargo vetalready coversevery one of those, so rustyline is the only unvetted crate:
Its exemption therefore moves 18.0.1 → 19.0.0 — a carry-forward of trust
already extended to this crate, not a grant to something new. The whole
supply-chain diff is one line.
Before / After
No user-visible change: same REPL, same line editing. Verified on the pinned
toolchain (1.95.0):
Compiling is not the same as working, so the REPL was also driven through the
real rustyline read loop rather than only the one-shot path the tests cover:
Risk
interactivefeature ofbashkit-cli; the library isuntouched. A major bump is the thing to be careful with, which is why the
REPL was exercised directly and not just built.
getrandom0.3.4 → 0.4.3 arrives transitively undertempfile. It isalready vetted at that version, and nothing in bashkit calls it directly.
Checklist
bashkit-clisuite (67 tests) plus aREPL smoke test; the bump adds no new code surface to test
surface; rustyline is an internal CLI dependency
Generated by Claude Code