Repository navigation
chore(builtins): sync uutils/coreutils argument surfaces and vendored modules - #2759
Merged
Merged
Conversation
… modules Regenerated by `bashkit-coreutils-port` against uutils/coreutils@d2d96946b. Utilities: cat ls mktemp od readlink realpath shuf stat tac tee truncate Vendored modules: format
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 439fd13 | Commit Preview URL Branch Preview URL |
Oct 19 2026, 10:12 AM |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Regenerated argument surfaces and vendored modules against
uutils/coreutils@
d2d96946b(was8613dffab). Two upstream argument-surfacechanges come through; everything else is the rev header bump.
od— the hiddenFILENAMEpositional gainsvalue_parser(OsStringValueParser::new()).tac—-s/--separatorgainsallow_hyphen_values(true), so ahyphen-leading separator (
tac -s -x) parses as a value rather than a flag,matching upstream.
No bashkit-side consumer changes are needed: #2754 landed
helpers::string_value/
string_values, which readod's arguments without naming the value type, sothe
OsStringValueParserswitch is absorbed.Why
The weekly Coreutils Args Drift run (run 39234801977) regenerated this diff and
pushed it to
chore/coreutils-args-drift, but could not open the PR — the job'sgh pr createis rejected with "GitHub Actions is not permitted to create orapprove pull requests", so the run goes red and the drift never surfaces for
review. This PR carries that pending drift; the workflow's token is fixed
separately in #2760.
Before / After
No observable behavior change for
od. Fortac, a hyphen-leading-svalueis now accepted instead of being parsed as a flag, which is upstream's behavior.
Verified locally on the drift branch with the pinned toolchain (1.95.0):
The spec-test gate is the same one the drift workflow runs before proposing a
diff, and it passed there too — the run only failed at the PR-creation step,
after regeneration and tests were green.
Risk
crates/bashkit/src/builtins/generated/.The
odvalue-type change is the case fix(builtins): read od's generated args under either clap value type #2754 made the consumers tolerate, witha guard test that fails loudly on an unhandled value type.
tac'sallow_hyphen_valuesonly widens what parses as a separator value.Checklist
od/tacunit tests, thebash spec suite, and the coreutils differential harness; generated code
carries no new test surface of its own
API change