[chaliy]

What changed

• In a terminal session, git commit without -m opens the editor on .git/COMMIT_EDITMSG, pre-filled with git's template, as real git does. Saving and quitting commits. Lines starting with # are dropped. An empty message aborts with git's message and exit 1, and so does :cq.
• vi gains :cq, which quits with exit status 1.
• Sessions set EDITOR=vi when it is unset. $VISUAL/$EDITOR are honored only as far as naming vi/vim; any other editor is reported as unavailable instead of being silently replaced.
• Outside a terminal, git commit without -m behaves as before (error: switch 'm' requires a value).

Why

Agents and users driving a terminal hit $EDITOR flows. With this change, git commit behaves like a real shell instead of failing. git rebase -i and crontab -e are not covered because neither command exists in bashkit. The new builtins::edit_file helper is the hook for future commands that need an editor.

Before / After

$ git commit
Before: error: switch 'm' requires a value
After:  vi opens on COMMIT_EDITMSG; Ofirst line<Esc>:wq commits "first line"
$ git commit         # then :wq with only the template
After:  Aborting commit due to empty commit message.   (exit 1)

Tests: terminal::tests::{git_commit_without_m_opens_editor, git_commit_editor_abort_paths, vi_cq_exits_nonzero}. The CI terminal step now runs with --features terminal,git so these tests execute. Locally, all 2856 lib tests pass with --features terminal,git, clippy is clean with and without terminal, and the git-only build is clean.

Risk

• Low. All changes are behind the terminal feature, which is off by default.
• The editor runs in-process from inside the git builtin, with no shell re-entry and no subprocess.

Checklist

• Tests added or updated
• Backward compatibility considered (non-terminal behavior unchanged)

---

Generated by Claude Code

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	bashkit	426013e	Commit Preview URL Branch Preview URL	Oct 07 2026, 05:03 AM