Give the toolbar back the space the title was providing - #39
Merged
Conversation
.primaryAction was the wrong fix and changed nothing on screen. A macOS toolbar packs its items left to right after the navigation slot, so a placement names where an item belongs without reserving any room to push it there. What removing the title took away was a space, and only a space replaces it. ToolbarSpacer is macOS 26, so below that a Spacer in the centre slot stands in — untested, since the machine this is developed on runs 26, which is why it is the fallback rather than the path everything takes. Claude-Session: https://claude.ai/code/session_01EqTTtmt4fyNtMxjc2ZVBzj
evandhoffman
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38: the History picker and the size and rate controls sit packed
against the build stamp on the left instead of at the trailing edge.
What I got wrong
Removing the window title took away the flexible space that had been pushing
those controls right — that part I had. The fix I shipped was to move them to
.primaryAction, on the theory that they had been relying on the title ratherthan saying where they belonged.
That changed nothing on screen, and the reason is the part I had wrong: a
macOS toolbar packs its items left to right after the navigation slot. A
placement names where an item belongs; it does not reserve any room to push it
there. What was removed was a space, and only a space replaces it.
ToolbarSpacer(.flexible)between the stamp and the controls is that space.The version caveat, stated rather than hidden
ToolbarSpaceris macOS 26. The package still builds for 14, where aSpacerin the
.principalslot is the nearest equivalent. That fallback is untested— the only machine this is developed on runs 26 — which is why it is the
fallback and not the path everything takes. Said plainly here and in the docs
rather than left to look verified.
Verification
215 tests,
swift build -c releaseand the lint gate clean. The docs and theAGENTS.mdnote from #38 are corrected, since both stated.primaryActionasthe fix.
The screen itself still needs a look — that is the whole point of the change.
https://claude.ai/code/session_01EqTTtmt4fyNtMxjc2ZVBzj