Repository navigation
ci: fix smoke test expectation after rule #00279 landed - #978
Merged
Merged
Conversation
Rule ev-flow#279 (TelephonyManager.getDeviceId + getSubscriberId) reaches 100% confidence on 13667fe3b0ad496a0cd157f34b7e0c991d72a4db.apk, so the sample now yields 21 behaviours instead of 20. The smoke test has failed on every run since that rule landed in quark-rules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 81.28% 81.28%
=======================================
Files 84 84
Lines 7923 7923
=======================================
Hits 6440 6440
Misses 1483 1483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haeter525
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smoke_test.ymlhas failed on every run since 2026-09-24, on master as well as on open PRs. The docs PRs it failed on did not cause it.Cause. The smoke test pins how many 100%-confidence behaviours each fixture APK yields. Rule #00279 (
TelephonyManager.getDeviceId+getSubscriberId, added for the Exodus analysis) reaches full confidence on13667fe3b0ad496a0cd157f34b7e0c991d72a4db.apk, so that sample now yields one behaviour more than the pinned value.Verified locally against
quark-engine/apk-sampleswith the current rule set:13667fe3…a4db.apkAhmyth.apk14d9f1a9…e273e.apk(The absolute numbers differ from CI's because the local run filters rules differently; the delta of exactly one behaviour on the a4db sample, and none on the other two, is what matters.)
Only the a4db expectation moves. I also checked the rule proposed in quark-rules #92 (
Runtime.exec+Process.getErrorStream): it changes none of the three counts, so no further update is needed when that merges.🤖 Generated with Claude Code