🛡️ Sentinel: [HIGH] Fix command injection in git clone mirror - #24
🛡️ Sentinel: [HIGH] Fix command injection in git clone mirror#24google-labs-jules[bot] wants to merge 2 commits into
Conversation
Adding `--` to the argument list for `git clone --mirror` ensures that user-controlled path strings (like `source_path` or `disk_path`) that happen to start with `-` are not misinterpreted as git command-line flags. This prevents potential command injection or erratic behavior in `api::repos`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Thanks for the contribution. A couple of things will help us review this faster:
See CONTRIBUTING.md. Update the PR and these notes will clear automatically. |
Adding `--` to the argument list for `git clone --mirror` ensures that user-controlled path strings (like `source_path` or `disk_path`) that happen to start with `-` are not misinterpreted as git command-line flags. This prevents potential command injection or erratic behavior in `api::repos`.
🚨 Severity: HIGH
💡 Vulnerability: User-supplied repository paths or names starting with
-could be interpreted as command-line flags bygit clone --mirrorinfork_repo.🎯 Impact: This could allow a malicious user to inject arbitrary git flags, leading to unexpected file operations, data leakage, or arbitrary command execution via features like
core.hooksPath.🔧 Fix: Appended the
--separator before the positional path arguments, forcing git to treat them strictly as file paths.✅ Verification:
cargo clippyandcargo checkcompile successfully, and the patch has passed code review.PR created automatically by Jules for task 632155665144112829 started by @euxaristia