🛡️ Sentinel: [CRITICAL] Fix uppercase header causing axum panic - #20
🛡️ Sentinel: [CRITICAL] Fix uppercase header causing axum panic#20google-labs-jules[bot] wants to merge 2 commits into
Conversation
Uppercase header names in `axum` cause panics during `IntoHeaderName` conversions, functioning as a localized DoS vulnerability. This commit changes `"X-Total-Count"` to the lowercase `"x-total-count"` to prevent axum panics on the `list_repos` route. Also added a comment explicitly warning against using uppercase letters in custom headers.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Thanks for the contribution. A couple of things will help us review this faster:
See CONTRIBUTING.md. Update the PR and these notes will clear automatically. |
Uppercase header names in `axum` cause panics during `IntoHeaderName` conversions, functioning as a localized DoS vulnerability. This commit changes `"X-Total-Count"` to the lowercase `"x-total-count"` to prevent axum panics on the `list_repos` route. Also ran `cargo update -p h2` to resolve a cargo audit failure (RUSTSEC-2026-0258) in the CI pipeline.
Fixes a critical vulnerability where an uppercase header name (
X-Total-Count) passed toaxum::http::HeaderMap::insert()caused a panic during string-to-header name conversion. HTTP header names must be lowercase. This commit changes the header tox-total-countand leaves a cautionary comment.PR created automatically by Jules for task 17015758347346998702 started by @euxaristia