Repository navigation
fix(editor): record unknown source kinds and keep collecting - #310
Merged
Merged
Conversation
primoco
added a commit
that referenced
this pull request
Nov 20, 2026
Contributor
|
Merged, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect_archive()looked upCOLLECTORS.get(src.kind)and called.fetch()on the result. A source whose kind has no registered collector (e.g. imported legacy data) raisedAttributeError, which was not caught, aborting the whole round before the remaining sources were read or the failure was recorded. The missing-collector case now records the same error/failure status as other source errors and continues. Test removes one kind from the registry and checks the other sources still produce items.Verification:
uv run pytest tests/test_pipeline.py -q— 17 passed, 1 skipped (PostgreSQL only).I have read and agree to the Contributor Licence Agreement in CLA.md.