Skip to content

fix(editor): record unknown source kinds and keep collecting - #310

Merged
primoco merged 1 commit into
eullm:mainfrom
Gabriele06-local:fix/unknown-source-kind
Nov 20, 2026
Merged

primoco merged 1 commit into
eullm:mainfrom
Gabriele06-local:fix/unknown-source-kind

Conversation

@Gabriele06-local

Copy link
Copy Markdown
Contributor

collect_archive() looked up COLLECTORS.get(src.kind) and called .fetch() on the result. A source whose kind has no registered collector (e.g. imported legacy data) raised AttributeError, which was not caught, aborting the whole round before the remaining sources were read or the failure was recorded. The missing-collector case now records the same error/failure status as other source errors and continues. Test removes one kind from the registry and checks the other sources still produce items.

Verification: uv run pytest tests/test_pipeline.py -q — 17 passed, 1 skipped (PostgreSQL only).

I have read and agree to the Contributor Licence Agreement in CLA.md.

@primoco
primoco merged commit 688e61a into eullm:main Nov 20, 2026
4 checks passed
@primoco

primoco commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Merged, thanks!

@primoco primoco mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants