Repository navigation
fix(editor): weight Search Console position over rows with a position - #308
Merged
Merged
Conversation
primoco
added a commit
that referenced
this pull request
Nov 20, 2026
Contributor
|
Merged, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
totals()andtop()weighted the position by impressions but divided by the sum of all impressions. Search Console stores NULL positions for rows with no reported position, so a page with(position 5, 100 impressions)plus(NULL, 100 impressions)was reported at position 2.5. The denominator now counts impressions only for rows that have a position, in both the totals and the per-key top list. Added a test with mixed NULL/non-NULL rows.Verification:
uv run pytest tests/test_weekly_search.py -q— 6 passed, 6 skipped (PostgreSQL only).I have read and agree to the Contributor Licence Agreement in CLA.md.