Repository navigation
fix(approvals): keep argument previews within their original size - #306
Merged
Merged
Conversation
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preview_arguments()truncated a long string to 2000 bytes and then appended an… [N bytes]suffix, making the preview longer than the original value (and inserting U+FFFD when the cut landed mid-character). The suffix length is now reserved before truncating, so the preview never exceeds the input and starts at a valid UTF-8 boundary. Unit test covers a 2001-byte ASCII string and a multi-byte one.Verification:
cargo fmt --check,cargo clippy -- -D warnings,cargo test --lib approvals::tests— 1 passed.I have read and agree to the Contributor Licence Agreement in CLA.md.