Repository navigation
Fix ethd bugs found by AI review - #2961
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
__lock_filewas set beforeflock -n. When a second./ethd updatelost the race, it exited 1 and__handle_errordeleted/tmp/<lock>, which belonged to the update still running. A third update would then create a fresh file, get the lock, and run alongside the first. Now__lock_fileis set only after flock succeeds. I tested both versions in the scratch dir while holding the lock: the old one deletes the file, the new one leaves it alone.git checkout mainwhen switching back tomainfrom atag-ran without${__as_owner}, so whenethdran asrootor asudouser, git could write files owned by that user. Also, the pattern^tag-*matches any branch starting withtag, not justtag-. Both are fixed.__install_dockerwritesdocker.sourcesbut never removed an olddocker.list. A host that once had Docker installed by an olderethd, then removed it and raninstallagain, would fail atapt-get updatewith "Conflicting values set for option Signed-By". It now deletesdocker.listfirst.