Skip to content

fix(web): bump vite to 7.3.7 - #169

Merged
skylenet merged 1 commit into
masterfrom
amp/vite-7.3.7
Nov 2, 2026
Merged

skylenet merged 1 commit into
masterfrom
amp/vite-7.3.7

Conversation

@samcm

@samcm samcm commented Nov 2, 2026

Copy link
Copy Markdown
Member

Bumps the web UI's vite 7.2.4 → 7.3.7 (range ^7.2.4 → ^7.3.7), which patches GHSA-v2wj-q39q-566r (high): server.fs.deny bypassed with ?raw / ?import&raw queries. 7.1.0–7.3.1 are affected; 7.3.7 also carries the later 7.3.x dev-server fixes.

Production is not affected: Dockerfile.web serves the built dist/ from nginx. The exposure is the dev server, and web/vite.config.ts sets server.host: true, so npm run dev listens on all interfaces and anyone on the same network can read denied files.

Checked with a canary web/.env and npx vite (bound to *):

Request 7.2.4 7.3.7
/.env 403 403
/.env?raw 200, contents leaked 403
/.env?import&raw 200, contents leaked 403

npm ci && npm run build passes on 7.3.7. The lockfile changes only vite and esbuild (0.25.12 → 0.28.2, which vite 7.3.7 requires).

The dev server sets server.host: true, so it listens on all interfaces.
vite 7.2.4 lets anyone on the network read files that server.fs.deny
blocks, such as .env, by adding ?raw (GHSA-v2wj-q39q-566r).

Amp-Thread-ID: https://ampcode.com/threads/T-01a19ad6-3d2c-751d-b36e-72e16768f99e
Co-authored-by: Sam Calder-Mason <samcaldermason@gmail.com>
@samcm
samcm requested a review from skylenet as a code owner November 2, 2026 09:16

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps vite 7.2.4 → 7.3.7 (fixes GHSA-v2wj-q39q-566r dev-server fs.deny bypass) with the required esbuild 0.25.12 → 0.28.2. Lockfile changes are limited to exactly the packages the bump implies, and OSV reports no known vulnerabilities for either new version. Clean.


Reviewed 2 changed file(s) @ 371297b9 — no blocking issues found.
"A child is a deadline with a face."

@skylenet
skylenet merged commit 8ba8846 into master Nov 2, 2026
4 checks passed
@skylenet
skylenet deleted the amp/vite-7.3.7 branch November 2, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants