Repository navigation
fix(web): bump vite to 7.3.7 - #169
Merged
Merged
Conversation
The dev server sets server.host: true, so it listens on all interfaces. vite 7.2.4 lets anyone on the network read files that server.fs.deny blocks, such as .env, by adding ?raw (GHSA-v2wj-q39q-566r). Amp-Thread-ID: https://ampcode.com/threads/T-01a19ad6-3d2c-751d-b36e-72e16768f99e Co-authored-by: Sam Calder-Mason <samcaldermason@gmail.com>
There was a problem hiding this comment.
Bumps vite 7.2.4 → 7.3.7 (fixes GHSA-v2wj-q39q-566r dev-server fs.deny bypass) with the required esbuild 0.25.12 → 0.28.2. Lockfile changes are limited to exactly the packages the bump implies, and OSV reports no known vulnerabilities for either new version. Clean.
Reviewed 2 changed file(s) @ 371297b9 — no blocking issues found.
"A child is a deadline with a face."
skylenet
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the web UI's vite 7.2.4 → 7.3.7 (range
^7.2.4→^7.3.7), which patches GHSA-v2wj-q39q-566r (high):server.fs.denybypassed with?raw/?import&rawqueries. 7.1.0–7.3.1 are affected; 7.3.7 also carries the later 7.3.x dev-server fixes.Production is not affected:
Dockerfile.webserves the builtdist/from nginx. The exposure is the dev server, andweb/vite.config.tssetsserver.host: true, sonpm run devlistens on all interfaces and anyone on the same network can read denied files.Checked with a canary
web/.envandnpx vite(bound to*):/.env/.env?raw/.env?import&rawnpm ci && npm run buildpasses on 7.3.7. The lockfile changes only vite and esbuild (0.25.12 → 0.28.2, which vite 7.3.7 requires).