Open
Conversation
Cafe137
reviewed
Apr 21, 2026
| import { ellipsis } from '../../utils/text' | ||
|
|
||
| export class List extends HistoryCommand implements LeafCommand { | ||
| public readonly name = 'list' |
Cafe137
reviewed
Apr 21, 2026
| key: 'index', | ||
| description: 'Index of the history item', | ||
| required: true, | ||
| autocompletePath: true, |
Collaborator
There was a problem hiding this comment.
Remove, this is not a path.
Cafe137
reviewed
Apr 21, 2026
| required: true, | ||
| autocompletePath: true, | ||
| }) | ||
| public index!: string |
Collaborator
There was a problem hiding this comment.
You can add type: 'number' in @Argument, and type it as public index!: number instead.
You can remove the parseInt on L23 too.
Cafe137
requested changes
Apr 21, 2026
added 5 commits
April 21, 2026 11:06
…e/swarm-cli into feat/implement-upload-history
Contributor
|
Cafe137
reviewed
Apr 21, 2026
Collaborator
There was a problem hiding this comment.
File name should be history-item.ts, e.g. withdraw-all.ts and cheque-command.ts; source files in this repository follow this convention.
Cafe137
reviewed
Apr 21, 2026
| reference: swarmHash, | ||
| stamp: this.stamp, | ||
| path: this.path, | ||
| uploadType: this.path ? 'file' : 'stdin', |
Collaborator
There was a problem hiding this comment.
this.path does not necessarily mean it is a file upload, it can still be a folder.
Please see and use uploadingFolder variable in src/command/upload.ts
(const uploadingFolder = !this.stdin && FS.statSync(this.path).isDirectory())
added 2 commits
April 21, 2026 20:31
…e/swarm-cli into feat/implement-upload-history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing history tracking for uploads, it gets saved in JSON format in a file called
upload-history.jsonin the.swarm-clifolder. Also to show the history a new command group is added with two commands,listandshow: