feat(client-clis): add besu frames exception mappings - #3682
Merged
danceratopz merged 2 commits intoOct 1, 2026
Merged
danceratopz merged 2 commits into
danceratopz merged 2 commits into
Conversation
LouisTsai-Csie
changed the title
LouisTsai-Csie
approved these changes
Oct 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8141 #3682 +/- ##
==========================================================
Coverage ? 93.45%
==========================================================
Files ? 576
Lines ? 33106
Branches ? 2923
==========================================================
Hits ? 30940
Misses ? 1619
Partials ? 547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danceratopz
changed the base branch from
devnets/frames/0
to
eips/amsterdam/eip-8141
October 1, 2026 11:29
danceratopz
approved these changes
Oct 1, 2026
danceratopz
left a comment
danceratopz
left a comment
Member
There was a problem hiding this comment.
Thanks! Let's get this in!
Updated to target the "eips" branch https://github.com/ethereum/execution-specs/tree/eips/amsterdam/eip-8141 from which the devnets branch get created.
Member
|
Ups, will need a rebase, I can handle this @jflo! |
Besu rejects invalid type-6 frame transactions with its own error strings, none of which BesuExceptionMapper knew about, so every EIP-8141 negative test failed with "Undefined exception message" rather than comparing the exception. Signed-off-by: jflo <justin+github@florentine.us>
Besu rejects invalid type-6 frame transactions with its own error
strings, none of which BesuExceptionMapper knew about, so every
EIP-8141 negative test failed with "Undefined exception message"
rather than comparing the exception.
Signed-off-by: jflo <justin+github@florentine.us>
danceratopz
force-pushed
the
frames-besu-exception-mapping
branch
2 times, most recently
from
October 1, 2026 11:40
6239cac to
70c780f
Compare
danceratopz
changed the title
Member
|
Will merge now; CI is failing due to two pre-existing issues that are documented here: |
danceratopz
merged commit Oct 1, 2026
489f5d1
into
ethereum:eips/amsterdam/eip-8141
24 of 26 checks passed
danceratopz
pushed a commit
that referenced
this pull request
Oct 1, 2026
* feat(consume): map Besu EIP-8141 frame transaction exceptions
Besu rejects invalid type-6 frame transactions with its own error
strings, none of which BesuExceptionMapper knew about, so every
EIP-8141 negative test failed with "Undefined exception message"
rather than comparing the exception.
Signed-off-by: jflo <justin+github@florentine.us>
* feat(consume): map Besu EIP-8141 frame transaction exceptions
Besu rejects invalid type-6 frame transactions with its own error
strings, none of which BesuExceptionMapper knew about, so every
EIP-8141 negative test failed with "Undefined exception message"
rather than comparing the exception.
Signed-off-by: jflo <justin+github@florentine.us>
(cherry picked from commit 489f5d1)
Member
|
@jflo I see that Besu's not configured for the frames hive test CI and dashboard yet (please ping when you have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maps error messages emitted by Besu to each type.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture